Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output
On 25.02.2016 09:52, Milan Kubík wrote: On 02/24/2016 07:05 PM, Martin Basti wrote: On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik NACK [mbasti@dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line too long (99 > 79 characters) ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line too long (99 > 79 characters) Sorry for that. Updated patch attached. -- Milan Kubik ACK Pushed to: master: b32c9d639ef8e3fa852fb07f9385ae7e7b48e00e ipa-4-3: 5ae12641426427552406af89feb15e9bcbad8db3 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output
On 02/24/2016 07:05 PM, Martin Basti wrote: On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik NACK [mbasti@dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line too long (99 > 79 characters) ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line too long (99 > 79 characters) Sorry for that. Updated patch attached. -- Milan Kubik From ecaa2d4ef7a2e4a5d5b953c56e6e5bd760f35012 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Mon, 15 Feb 2016 16:54:34 +0100 Subject: [PATCH] ipatests: extend permission plugin test with new expected output --- ipatests/test_xmlrpc/test_old_permission_plugin.py | 14 ++ ipatests/test_xmlrpc/test_permission_plugin.py | 18 ++ 2 files changed, 32 insertions(+) diff --git a/ipatests/test_xmlrpc/test_old_permission_plugin.py b/ipatests/test_xmlrpc/test_old_permission_plugin.py index 9e4b561a6f8ff4d6eac767f7f24e35ee4a910eff..09f43fee8c60e4e97d233d256f046fef44d31acf 100644 --- a/ipatests/test_xmlrpc/test_old_permission_plugin.py +++ b/ipatests/test_xmlrpc/test_old_permission_plugin.py @@ -524,6 +524,13 @@ class test_old_permission(Declarative): 'subtree': u'ldap:///%s' % users_dn, }, ], +messages=({ +'message': (u'Search result has been truncated to ' +'configured search limit.'), +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +},), ), ), @@ -577,6 +584,13 @@ class test_old_permission(Declarative): DN(res['dn']).endswith(DN(api.env.container_permission, api.env.basedn)) and 'ipapermission' in res['objectclass']], +messages=({ +'message': (u'Search result has been truncated to ' +'configured search limit.'), +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +},), ), ), diff --git a/ipatests/test_xmlrpc/test_permission_plugin.py b/ipatests/test_xmlrpc/test_permission_plugin.py index 01294665814fc667f932272ee8bc3077583b67df..8026e84366e3b9056ed6e2ff6d76c58bdc95140e 100644 --- a/ipatests/test_xmlrpc/test_permission_plugin.py +++ b/ipatests/test_xmlrpc/test_permission_plugin.py @@ -816,6 +816,15 @@ class test_permission(Declarative): 'ipapermlocation': [users_dn], }, ], +messages=( +{ +'message': (u'Search result has been truncated to ' +'configured search limit.'), +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +}, +), ), ), @@ -871,6 +880,15 @@ class test_permission(Declarative): DN(res['dn']).endswith(DN(api.env.container_permission, api.env.basedn)) and 'ipapermission' in res['objectclass']], +messages=( +{ +'message': (u'Search result has been truncated to ' +'configured search limit.'), +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +}, +), ), ), -- 2.7.1 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut
Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output
On 24.02.2016 08:34, Milan Kubík wrote: On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik NACK [mbasti@dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line too long (99 > 79 characters) ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line too long (99 > 79 characters) -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output
On 02/18/2016 03:52 PM, Milan Kubík wrote: On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik Review bump. -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output
On 02/15/2016 04:59 PM, Milan Kubík wrote: Patch attached. Applies on ipa-4-3 as well. Updated version of patch fixes test_old_permission_plugin as well. -- Milan Kubik From 518f85240a14f256b5cc8542f66d3766a66b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Mon, 15 Feb 2016 16:54:34 +0100 Subject: [PATCH] ipatests: extend permission plugin test with new expected output --- ipatests/test_xmlrpc/test_old_permission_plugin.py | 12 ipatests/test_xmlrpc/test_permission_plugin.py | 16 2 files changed, 28 insertions(+) diff --git a/ipatests/test_xmlrpc/test_old_permission_plugin.py b/ipatests/test_xmlrpc/test_old_permission_plugin.py index 9e4b561a6f8ff4d6eac767f7f24e35ee4a910eff..c225d784d440751c09e7b16909fc8ad89f55c344 100644 --- a/ipatests/test_xmlrpc/test_old_permission_plugin.py +++ b/ipatests/test_xmlrpc/test_old_permission_plugin.py @@ -524,6 +524,12 @@ class test_old_permission(Declarative): 'subtree': u'ldap:///%s' % users_dn, }, ], +messages=({ +'message': u'Search result has been truncated to configured search limit.', +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +},), ), ), @@ -577,6 +583,12 @@ class test_old_permission(Declarative): DN(res['dn']).endswith(DN(api.env.container_permission, api.env.basedn)) and 'ipapermission' in res['objectclass']], + messages=({ +'message': u'Search result has been truncated to configured search limit.', +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' + },), ), ), diff --git a/ipatests/test_xmlrpc/test_permission_plugin.py b/ipatests/test_xmlrpc/test_permission_plugin.py index 01294665814fc667f932272ee8bc3077583b67df..d641a2d078e0f275a44bbc539aef1352c023ae9b 100644 --- a/ipatests/test_xmlrpc/test_permission_plugin.py +++ b/ipatests/test_xmlrpc/test_permission_plugin.py @@ -816,6 +816,14 @@ class test_permission(Declarative): 'ipapermlocation': [users_dn], }, ], +messages=( +{ +'message': u'Search result has been truncated to configured search limit.', +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +}, +), ), ), @@ -871,6 +879,14 @@ class test_permission(Declarative): DN(res['dn']).endswith(DN(api.env.container_permission, api.env.basedn)) and 'ipapermission' in res['objectclass']], +messages=( +{ +'message': u'Search result has been truncated to configured search limit.', +'code': 13017, +'type': u'warning', +'name': u'SearchResultTruncated' +}, +), ), ), -- 2.7.1 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code