Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-18 Thread Jan Pazdziora
On Thu, Sep 17, 2015 at 01:47:29PM +0200, Tomas Babej wrote: > also guilty of this mishap. This poses certain problems, as we're trying > to automate the bookkeeping and pushing-related processes with ipatool [1]. [...] > This would mean: > * Patches fixing an issue described only in BZ (rare

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-18 Thread Petr Spacek
On 17.9.2015 17:42, Alexander Bokovoy wrote: > On Thu, 17 Sep 2015, Rob Crittenden wrote: >> Alexander Bokovoy wrote: >>> On Thu, 17 Sep 2015, Jakub Hrozek wrote: On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: > >Speaking as IPA package maitainer in RHEL, I would like

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Lenka Doudova
Hi, though I'm not a fellow developer, I'd like to point out that the habit you mentioned (putting a link into commit message) is indeed documented on wiki [1]. It's just on a spot where it's not that much visible. Sorry if I misunderstood the point of your email. Lenka [1]

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Martin Kosek
On 09/17/2015 01:47 PM, Tomas Babej wrote: > Hi fellow developers, > > more or less we tend to stick to the tradition of linking Trac tickets > to the commit messages of the patches we send to the list. > > However, every now and then, a patch lands on the list, which is either > linked to a BZ

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or less we tend to stick to the tradition of linking Trac tickets to the commit messages of the patches we send to the list. However, every now and then, a patch lands on the list,

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Martin Kosek
On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: > On Thu, 17 Sep 2015, Martin Kosek wrote: >> On 09/17/2015 01:47 PM, Tomas Babej wrote: >>> Hi fellow developers, >>> >>> more or less we tend to stick to the tradition of linking Trac tickets >>> to the commit messages of the patches we send to

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Petr Vobornik
On 09/17/2015 01:53 PM, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or less we tend to stick to the tradition of linking Trac tickets to the commit messages of the patches we send to the list. However, every now and then, a patch lands on the

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Tomas Babej
On 09/17/2015 01:53 PM, Martin Kosek wrote: > On 09/17/2015 01:47 PM, Tomas Babej wrote: >> Hi fellow developers, >> >> more or less we tend to stick to the tradition of linking Trac tickets >> to the commit messages of the patches we send to the list. >> >> However, every now and then, a patch

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or less we tend to stick to the tradition of linking Trac tickets to the commit messages of

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Tomas Babej wrote: On 09/17/2015 01:53 PM, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or less we tend to stick to the tradition of linking Trac tickets to the commit messages of the patches we send to the list. However,

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Tomas Babej
On 09/17/2015 01:55 PM, Lenka Doudova wrote: > Hi, > > though I'm not a fellow developer, I'd like to point out that the habit $ git shortlog | grep Lenka tells me otherwise. This thread is applicable to everybody contributing to the FreeIPA git repo, so maybe developer was a poor choice of

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Jan Cholasta
On 17.9.2015 14:08, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or less we tend to stick to the tradition of

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Jan Cholasta wrote: On 17.9.2015 14:08, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more or

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Petr Vobornik
On 09/17/2015 04:47 PM, Jakub Hrozek wrote: On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: Speaking as IPA package maitainer in RHEL, I would like to have ticket link in every commit in maintenance branches. If a commit goes to the master branch only, I'm OK with it not

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Rob Crittenden
Alexander Bokovoy wrote: > On Thu, 17 Sep 2015, Jakub Hrozek wrote: >> On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: >>> >Speaking as IPA package maitainer in RHEL, I would like to have ticket >>> >link in every commit in maintenance branches. If a commit goes to the >>>

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Simo Sorce
On Thu, 2015-09-17 at 14:07 +0200, Tomas Babej wrote: > > On 09/17/2015 01:53 PM, Martin Kosek wrote: > > On 09/17/2015 01:47 PM, Tomas Babej wrote: > >> Hi fellow developers, > >> > >> more or less we tend to stick to the tradition of linking Trac tickets > >> to the commit messages of the

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Rob Crittenden wrote: Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Jakub Hrozek wrote: On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: >Speaking as IPA package maitainer in RHEL, I would like to have ticket >link in every commit in maintenance

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Jan Cholasta
On 17.9.2015 15:02, Milan Kubík wrote: On 09/17/2015 02:51 PM, Jan Cholasta wrote: On 17.9.2015 14:08, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Alexander Bokovoy
On Thu, 17 Sep 2015, Jakub Hrozek wrote: On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: >Speaking as IPA package maitainer in RHEL, I would like to have ticket >link in every commit in maintenance branches. If a commit goes to the >master branch only, I'm OK with it not

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Jakub Hrozek
On Thu, Sep 17, 2015 at 03:55:35PM +0300, Alexander Bokovoy wrote: > >Speaking as IPA package maitainer in RHEL, I would like to have ticket > >link in every commit in maintenance branches. If a commit goes to the > >master branch only, I'm OK with it not having a ticket link. So that's > >where I

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Milan Kubík
On 09/17/2015 02:51 PM, Jan Cholasta wrote: On 17.9.2015 14:08, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 02:00 PM, Alexander Bokovoy wrote: On Thu, 17 Sep 2015, Martin Kosek wrote: On 09/17/2015 01:47 PM, Tomas Babej wrote: Hi fellow developers, more