Re: [Freeipa-devel] Patch for #1539

2014-06-09 Thread Petr Viktorin
On 06/09/2014 08:21 AM, Martin Kosek wrote: On 06/06/2014 05:47 PM, Nathaniel McCallum wrote: On Fri, 2014-06-06 at 11:43 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 11:06 -0400, Nathaniel McCallum wrote: On Fri, 2014-06-06 at 08:00 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 10:30

Re: [Freeipa-devel] Patch for #1539

2014-06-09 Thread Simo Sorce
Pushed to master: bfdbd3b6ad7c437e7dd293d2488b2d53f4ea7ba6 Hello, This patch broke some of our tests. ipatests.test_ipaserver.test_changepw:test_changepw.test_invalid_auth ipatests.test_xmlrpc.test_user_plugin:test_denied_bind_with_expired_principal.test_1_bind_as_test_user

Re: [Freeipa-devel] Patch for #1539

2014-06-06 Thread Martin Kosek
On 05/31/2014 03:27 AM, Simo Sorce wrote: I have rebased theold patch attached to the ticket, unfortunately I haven't had time to test it yet, but didn't want to lose it in some branch. Simo. I tested the patch and it worked fine, code also reads OK. Thus, I am willing to ACK it. I am just

Re: [Freeipa-devel] Patch for #1539

2014-06-06 Thread Simo Sorce
On Fri, 2014-06-06 at 10:30 +0200, Martin Kosek wrote: On 05/31/2014 03:27 AM, Simo Sorce wrote: I have rebased theold patch attached to the ticket, unfortunately I haven't had time to test it yet, but didn't want to lose it in some branch. Simo. I tested the patch and it worked

Re: [Freeipa-devel] Patch for #1539

2014-06-06 Thread Nathaniel McCallum
On Fri, 2014-06-06 at 08:00 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 10:30 +0200, Martin Kosek wrote: On 05/31/2014 03:27 AM, Simo Sorce wrote: I have rebased theold patch attached to the ticket, unfortunately I haven't had time to test it yet, but didn't want to lose it in some

Re: [Freeipa-devel] Patch for #1539

2014-06-06 Thread Simo Sorce
On Fri, 2014-06-06 at 11:06 -0400, Nathaniel McCallum wrote: On Fri, 2014-06-06 at 08:00 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 10:30 +0200, Martin Kosek wrote: On 05/31/2014 03:27 AM, Simo Sorce wrote: I have rebased theold patch attached to the ticket, unfortunately I

Re: [Freeipa-devel] Patch for #1539

2014-06-06 Thread Nathaniel McCallum
On Fri, 2014-06-06 at 11:43 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 11:06 -0400, Nathaniel McCallum wrote: On Fri, 2014-06-06 at 08:00 -0400, Simo Sorce wrote: On Fri, 2014-06-06 at 10:30 +0200, Martin Kosek wrote: On 05/31/2014 03:27 AM, Simo Sorce wrote: I have rebased