Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Adam Young
On 08/01/2011 06:34 AM, Alexander Bokovoy wrote: Hi, while investigating #1549 and #1550 I stumbled upon a problem. We create Param(s) as read only entities. This means that using standard methods, any modifications to Param instances are denied. What happens in #1549 and #1550 is that the code

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Alexander Bokovoy
On 01.08.2011 16:13, Adam Young wrote: On 08/01/2011 06:34 AM, Alexander Bokovoy wrote: Hi, while investigating #1549 and #1550 I stumbled upon a problem. We create Param(s) as read only entities. This means that using standard methods, any modifications to Param instances are denied. What

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Alexander Bokovoy
On 01.08.2011 16:13, Adam Young wrote: OTOH, if the env is something that can change, then we should not require it for the validate call. Is it possible to validate without an env? I looked at other exceptions thrown and now pass self.cli_name if it exists and self.name otherwise -- this is

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Adam Young
I don't really have the context to ACK it, but it looks a lot better to me than the previous solution. On 08/01/2011 09:53 AM, Alexander Bokovoy wrote: On 01.08.2011 16:13, Adam Young wrote: OTOH, if the env is something that can change, then we should not require it for the validate call.

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Alexander Bokovoy
On 01.08.2011 17:00, Adam Young wrote: I don't really have the context to ACK it, but it looks a lot better to me than the previous solution. Thanks. Here is what I get without and with the patch: -- $ ./ipa automountkey-add pune Map: ipa: ERROR:

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Adam Young
On 08/01/2011 10:01 AM, Alexander Bokovoy wrote: On 01.08.2011 17:00, Adam Young wrote: I don't really have the context to ACK it, but it looks a lot better to me than the previous solution. Thanks. Here is what I get without and with the patch: -- $ ./ipa

Re: [Freeipa-devel] environment in Param(s)

2011-08-01 Thread Alexander Bokovoy
On 01.08.2011 17:15, Adam Young wrote: On 08/01/2011 10:01 AM, Alexander Bokovoy wrote: On 01.08.2011 17:00, Adam Young wrote: I don't really have the context to ACK it, but it looks a lot better to me than the previous solution. Thanks. Here is what I get without and with the patch: