RE: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-20 Thread Liebig, Holger
One problem is, that this OEM command requires admin privilege, which would have to be specified on the command line with -l admin. That is annoying. We could up the default privilege to admin, but my general attitude is to max the privilege level at whatever is necessary for the tool.

RE: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-20 Thread Liebig, Holger
On 08/18/10 22:40, Albert Chu: Unfortunately due to memory constrains in the previous BMC generation the maximum length of a single response is limited to 64bytes, while on the current product line you should be able to get the full 100bytes 0x64 = 100 Random coincidence ? It look

RE: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-20 Thread Albert Chu
On Fri, 2010-08-20 at 05:20 -0700, Liebig, Holger wrote: One problem is, that this OEM command requires admin privilege, which would have to be specified on the command line with -l admin. That is annoying. We could up the default privilege to admin, but my general attitude is to

RE: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-19 Thread Albert Chu
Hey Holger, On Wed, 2010-08-18 at 08:25 -0700, Liebig, Holger wrote: Hey Holger, If you can, that'd be great (LMK if you begin something, so I won't start to work on it too). Because this wouldn't be a straight OEM code - string conversion (you're instead calling another Fujitsu

[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-18 Thread Albert Chu
Hey Dan, Responses inlined below. On Tue, 2010-08-17 at 16:19 -0700, Dan Lukes wrote: On 08/17/10 23:10, Albert Chu: Attached is my reworked patch for ipmi-oem. Can you give it a shot and LMK if it works? Done. Some notes: 1. -- if user call for record id = 65536 the

RE: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-17 Thread Albert Chu
Hey Holger, (BTW, I'm splitting this thread into two, so the response to the other part is in the new thread). I had intended to add this into ipmi-sel, but w/o a mobo to test on I let it pass. If you're game to test a patch for me, I'd be glad to implement it into ipmi-sel. I'm busy

[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-17 Thread Albert Chu
Hey Dan, Finally got a chance to look through your patch. For the most part it's fine. I'll tweak a few formatting things to be consistent to other parts of FreeIPMI, and I think I'll do first and last instead of 0 or -1 for the first/last SEL entry. But I'm a tad confused on this in your

Re: [Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-17 Thread Albert Chu
Hey Dan, On Tue, 2010-08-17 at 11:04 -0700, Albert Chu wrote: Hey Dan, Finally got a chance to look through your patch. For the most part it's fine. I'll tweak a few formatting things to be consistent to other parts of FreeIPMI, and I think I'll do first and last instead of 0 or -1 for

[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-17 Thread Albert Chu
Hey Dan, Attached is my reworked patch for ipmi-oem. Can you give it a shot and LMK if it works? I cleaned up some chunks for code consistency to other code in ipmi-oem and added a manpage entry. I ended up removing the first and last because I guess I don't see users wanting to/commonly using

[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-17 Thread Dan Lukes
On 08/17/10 23:10, Albert Chu: Attached is my reworked patch for ipmi-oem. Can you give it a shot and LMK if it works? Done. Some notes: 1. -- if user call for record id = 65536 the number record ID is silently changed to something else. I recommend not to allow out-of-range

[Freeipmi-devel] Re: Fujitsu's iRMC S2 - support for get SEL entry long text within ipmi-oem

2010-08-16 Thread Albert Chu
Hi Dan, In the fact, it would be better to use the function as part of interpret-oem-data within ipmi-sel, but it require better knowledge of current implementation of ipmi-sel than I have. Someone with better skills may implement it (using the code from patch). Then I can help with