Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix
I added a k_g_len component to workaround the issue. The patch is in the head and 0.3.X branch now. I also found a ipmiconsole state machine bug along the way too. Thanks, Al Hey Levi, I've commited the bmc-config strdup fix and bmc-config 0x support into the CVS head and 0.3.X branch. The ipmiconsole part is fine, except for the part that you assume the k_g input into libipmiconsole is 20 bytes. I can understand that you didn't want to change the API format, but I think it'll just have to change. I'll figure out how to adjust it sometime tomorrow. Thanks, Al This patch includes the changes to both ipmiconsole and bmc-config, including a bugfix in bmc-config to fix a memory bug due to a missing strdup. I also noticed that several of the bmc-config sections return non-fatal error codes; I'm assuming that this means there were configuration items within that didn't exist on the BMC. Is this correct? --Levi ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix
Hi Levi, Thanks. I hope I can look at the patch later today or possibly tomorrow. I also noticed that several of the bmc-config sections return non- fatal error codes; I'm assuming that this means there were configuration items within that didn't exist on the BMC. Is this correct? Yup. For example, there are some fields that are optional, like the arp stuff in the lan cmd. Also, when committing, some vendors left fields as read only even though they should be writeable. Thanks, Al On Thu, 2007-05-03 at 11:51 -0600, Levi Pearson wrote: This patch includes the changes to both ipmiconsole and bmc-config, including a bugfix in bmc-config to fix a memory bug due to a missing strdup. I also noticed that several of the bmc-config sections return non-fatal error codes; I'm assuming that this means there were configuration items within that didn't exist on the BMC. Is this correct? --Levi ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
Re: [Freeipmi-devel] Patch for hex k_g keys in ipmiconsole and bmc-config + bugfix
Hey Levi, I've commited the bmc-config strdup fix and bmc-config 0x support into the CVS head and 0.3.X branch. The ipmiconsole part is fine, except for the part that you assume the k_g input into libipmiconsole is 20 bytes. I can understand that you didn't want to change the API format, but I think it'll just have to change. I'll figure out how to adjust it sometime tomorrow. Thanks, Al This patch includes the changes to both ipmiconsole and bmc-config, including a bugfix in bmc-config to fix a memory bug due to a missing strdup. I also noticed that several of the bmc-config sections return non-fatal error codes; I'm assuming that this means there were configuration items within that didn't exist on the BMC. Is this correct? --Levi ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
