> On Fri, 2007-04-27 at 17:28 -0700, Albert Chu wrote:
>> Hey Levi,
>>
>> Looks good. I fixed the one or two remaining nit picks I found. It's
>> now
>> in the 0.3.X stable line and CVS head.
>>
>> Were you going to work on the ipmiconsole and bmc-config equivalent
>> support too?
>
> Yup, I'll
On Fri, 2007-04-27 at 17:28 -0700, Albert Chu wrote:
> Hey Levi,
>
> Looks good. I fixed the one or two remaining nit picks I found. It's now
> in the 0.3.X stable line and CVS head.
>
> Were you going to work on the ipmiconsole and bmc-config equivalent
> support too?
Yup, I'll be working on
Hey Levi,
Oh, and I think I fixed that 20 byte k_g corner case you mentioned
earlier. It's in the stable 0.3.X branch.
Al
> Hey Levi,
>
> Looks good. I fixed the one or two remaining nit picks I found. It's now
> in the 0.3.X stable line and CVS head.
>
> Were you going to work on the ipmicon
Hey Levi,
Looks good. I fixed the one or two remaining nit picks I found. It's now
in the 0.3.X stable line and CVS head.
Were you going to work on the ipmiconsole and bmc-config equivalent
support too?
Thanks,
Al
> On Thu, 2007-04-26 at 22:47 -0700, Albert Chu wrote:
>> Hey Levi,
>>
>> Looks
On Thu, 2007-04-26 at 22:47 -0700, Albert Chu wrote:
> Hey Levi,
>
> Looks pretty good. Some minor nit-picks.
Fixed those, and I prevented printing out a key starting with a literal
'0x' in ascii.
--Levi
Index: common/src/ipmi-common.c
===
> Levi Pearson wrote:
>
>> This version should address the issues from the review of the previous
>> patch. I've tested this one a bit more and it seems pretty solid to me.
>
> This is probably a very uncommon use case: Since the "0x" prefix is used
> for specifying keys in hex format you cannot
Levi Pearson wrote:
This version should address the issues from the review of the previous
patch. I've tested this one a bit more and it seems pretty solid to me.
This is probably a very uncommon use case: Since the "0x" prefix is used
for specifying keys in hex format you cannot encode keys
Hey Levi,
Looks pretty good. Some minor nit-picks.
1)
+ q = buf;
I think this line is unnecessary???
2)
ipmipower manpage for describing the new possible hex input for -k and -K.
3)
ipmipower_config.c: In function `ipmipower_config_cmdline_parse':
ipmipower_config.c:387: warning:
Hey Levi,
> > I think we want:
> >
> > if (!(isgraph(k_g[i]) || k_g[i] == ' ')
> > || (foundnull && k_g[i] != '\0')
>
> If the null check is true, there's a continue, which skips the second
> check entirely. So whenever the second check is run, we know k_g[i] !=
> '\0', so we only need to c
On Wed, 2007-04-25 at 18:28 -0700, Al Chu wrote:
>
> Thinking about this a bit. I think the hex mode should be the non-
> default. The reason is that atleast a few other apps (most notably
> Conman) already assume string input by default. Some others might have
> scripts and such. Would it be
Hey Levi,
And one more comment:
7)
I think you missed several uses of conf->k_g in ipmipower_powercmd.c.
Al
> Hey Levi,
>
>> I decided to go with the hex by default, strings prefixed with s:
>> method.
>
> Thinking about this a bit. I think the hex mode should be the non-
> default. The reas
Hey Levi,
> I decided to go with the hex by default, strings prefixed with s:
> method.
Thinking about this a bit. I think the hex mode should be the non-
default. The reason is that atleast a few other apps (most notably
Conman) already assume string input by default. Some others might have
12 matches
Mail list logo
