Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

[Ingo van Lil]

Levi Pearson wrote:


This version should address the issues from the review of the previous
patch.  I've tested this one a bit more and it seems pretty solid to me.


This is probably a very uncommon use case: Since the 0x prefix is used 
for specifying keys in hex format you cannot encode keys that actually 
start with a literal 0x in string format. This is probably a very 
uncommon use case, but you should still fall back to hex syntax in this 
case. Otherwise format_kg() might format a key in a way that can't be 
read by parse_kg().


Cheers,
Ingo


___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/freeipmi-devel

Re: [Freeipmi-devel] Patch for hex k_g keys in ipmipower, take 2

[Albert Chu]

Hey Levi,

Oh, and I think I fixed that 20 byte k_g corner case you mentioned
earlier.  It's in the stable 0.3.X branch.

Al

 Hey Levi,

 Looks good.  I fixed the one or two remaining nit picks I found.  It's now
 in the 0.3.X stable line and CVS head.

 Were you going to work on the ipmiconsole and bmc-config equivalent
 support too?

 Thanks,
 Al

 On Thu, 2007-04-26 at 22:47 -0700, Albert Chu wrote:
 Hey Levi,

 Looks pretty good.  Some minor nit-picks.

 Fixed those, and I prevented printing out a key starting with a literal
 '0x' in ascii.

  --Levi



 --
 Albert Chu
 [EMAIL PROTECTED]
 925-422-5311
 Computer Scientist
 High Performance Systems Division
 Lawrence Livermore National Laboratory



-- 
Albert Chu
[EMAIL PROTECTED]
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory



___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/freeipmi-devel