Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Reasamp
On Fri, 11 Jan 2008 05:13:20 +0600, Ray Benjamin <[EMAIL PROTECTED]> wrote: Reasamp, Yes, you should not duplicate code. If the code is going to be used in two different places, make it a function, that way, if there are bugs or improvements, they only have to be done in a single place. Do

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Ray Benjamin
Reasamp, Yes, you should not duplicate code. If the code is going to be used in two different places, make it a function, that way, if there are bugs or improvements, they only have to be done in a single place. Functions are also appropriate as a way to help document the code and make the a

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Reasamp
Just found another very minor, related, issue After I make the change Dan described just inside DocumentPane.setHTMLView of SimplyHTML, it misses the change when the HTML code panel opens first on clicking a node. Say if I OK a particular change while the HTML code window is open, and re-clic

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Dan Polansky
Disabling direct editing is not a good idea IMHO. Dan - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Ray Benjamin
It does make sense to remove the HTML and BODY tags as well. I should have thought of that, myself, doh. Before we think about disabling a feature like direct editing of the HTML, we should find out if any of our users are already depending on it. There are some people on every open source pro

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Ray Benjamin
This looks like an excellent solution to me. Ray Dan Polansky wrote: Hi, The STYLE tag should not be stored in every single node; HTML styling can be made globally accross the whole map, using a property from user.properties. The HEAD tag including STYLE tag can be removed from the Simply

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-10 Thread Reasamp
> * if (!Util.preferenceIsTrue("writeHead","true")) > *newText = newText.replaceAll("(?ims).*?( and tags, because they too can contain similar wide-scale attributes inside the tags. So maybe I'd prefer something similar to this: newText = newText.replaceAll("(?ims).*?\\

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-09 Thread Dan Polansky
Hi, The STYLE tag should not be stored in every single node; HTML styling can be made globally accross the whole map, using a property from user.properties. The HEAD tag including STYLE tag can be removed from the SimplyHTML code view too, using the following patch of DocumentPane.java of the met

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-08 Thread Reasamp
Hmm, I'll wait and see what others think of it. And yes, some very specific parts of freemind, by my opinion did seem to get overly feature-heavy :( But I'm sure we can all fix things up later, maybe after 0.9.0. And I think I completely missed the development of the extension interfaces, an

Re: [Freemind-developer] HTML formatting in header styles lost

2008-01-08 Thread Ray Benjamin
Reasamp, Welcome to the project. Your enthusiasm and energy are admirable. I'm glad you've chosen to work with us. I'm especially pleased that you are willing to jump right in to fixing problems you encounter. I'm Ray Benjamin, self-appointed project nit-picker and cheerleader. My background i

[Freemind-developer] HTML formatting in header styles lost

2008-01-08 Thread Reasamp
I'm not quites sure who here's working on it right now, so I'm posting it here. When I saw the HTML editor with long notes, impression was that every node is a miniature HTML document and just naively I expected that if I make changes inside