Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-05-14 Thread Alexis Moinet
Hi sorry for being quiet on this but I was unavailable for a while. I've updated to rev. 8abc0edd.. (current master) and it now seems stable, after many tries and using xfreerdp for a while, I've not been able to reproduce the problem yet. I'm aware that the fix you made is supposed to fix sym

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-05-01 Thread Marc-André Moreau
Hi Idan, There are many things which deserve to be improved regarding the reconnection, but I don't think merging "connect" and "reconnect" functions is one of them. However, you made me look at the code and realize that the recent addition of autoreconnection indeed created functions similar in f

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Idan Freiberg
Hi Marc, Thanks for the update. I dont like that design when we use rdp_reconnect as a seperate function, for second connection. What do you think about merging it to the rdp_connect function so well not have to maintain them both? Maybe we can do full cleanup and jump again to connect. On May

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Marc-André Moreau
Hi Idan, I just found another problem, which I fixed here: https://github.com/awakecoding/FreeRDP/commit/5b0822a43769c7e00fdbdbd0e3a2af83a8e85dfe On reconnection, we weren't getting rid of the initial settings->LoadBalanceInfo, which caused it to be reused even if the redirected packet did not co

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Marc-André Moreau
Hi, It depends on the type of brokering you are doing. In the case of cookie-based redirection, you connect to the broker, get a connection cookie, and reconnect to the broker with that cookie to then be redirected to the correct machine but through the broker. IP-based redirection can also be do

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Idan Freiberg
Hi, Afak, you shouldn't connect to the connection broker directly. The process is : 1. Connect to a RDSH server which is a farm member. 2. That server should query the broker whether to connect you to this server or another. 3. If the broker says that you may connect to another RDSH, then the firs

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Marc-André Moreau
Hi Alexis, From my understanding, your deployment does not use a TS Gateway, which should make debugging easier for us. Knowing this, here's what you can do: 1) Get mstsc to connect through the broker correctly 2) Capture traffic with wireshark while mstsc connects There should be two TCP connec

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Marc-André Moreau
Hi Alexis, You can build with WITH_DEBUG_REDIR, and see what redirection packet you are getting. You are getting the redirection packet, but reconnection to the redirected machine fails. In the case of the person I was assisting the other day, I had issues connecting with mstsc, so it was hard to

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Peter Astrand
On Tue, 29 Apr 2014, Clay Thomas wrote: > For the time being, I'm testing rdesktop in place of freeRDP. It doesn't > support NLA and requires two logins when used against a Connection Broker, > but at least it works and I don't have to change any of my network or > server settings at this time. T

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-30 Thread Alexis Moinet
Hello On 29/04/14 17:02, Marc-André Moreau wrote: > I've been investigating this all of yesterday with someone on IRC. I fixed > the double free issue on my branch. > https://github.com/awakecoding/FreeRDP/commit/c2a59c23a7b8eb262209bdadb66fe1e429ec943e Indeed, I can confirm no double free anymor

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-29 Thread Clay Thomas
Thanks for the replies guys! Definitely looks like the same issue that I'm having. I find it disconcerting that this is an issue that's been open for a year with no resolution. I could kill load balancing provided by the Connection Broker and just rely on round robin DNS, but since I have a mixed

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-29 Thread Marc-André Moreau
Hi, I've been investigating this all of yesterday with someone on IRC. I fixed the double free issue on my branch. https://github.com/awakecoding/FreeRDP/commit/c2a59c23a7b8eb262209bdadb66fe1e429ec943e This problem would only occur in the case of a failed redirection. However, I suspect there is

Re: [Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-29 Thread Alexis Moinet
On 28/04/14 04:08, Clay Thomas wrote: > Hey all! > > I'm running into an issue with FreeRDP closing when I connect to a Server > 2008 R2 RDS farm that has a Connection Broker and round robin DNS. I am > using the latest testing FreeRDP package included with OpenThinClient V2. > Currently, the farm

[Freerdp-devel] Connection Broker and Round Robin DNS

2014-04-27 Thread Clay Thomas
Hey all! I'm running into an issue with FreeRDP closing when I connect to a Server 2008 R2 RDS farm that has a Connection Broker and round robin DNS. I am using the latest testing FreeRDP package included with OpenThinClient V2. Currently, the farm has NLA disabled and I am not passing any login i