This patch seem to work for me.
Jay
diff --git a/X11/xf_win.c b/X11/xf_win.c
index 1666437..dc56496 100644
--- a/X11/xf_win.c
+++ b/X11/xf_win.c
@@ -362,7 +362,127 @@ static void
l_ui_polygon(struct rdp_inst * inst, uint8 opcode, uint8 fillmode, RD_POINT * point,
int npoints, RD_BRUSH * brush,
Example
You should change XFillPolygon calls
+ XFillPolygon(xfi->display, xfi->wnd, xfi->gc,
+ (XPoint *) point, npoints, Complex,
CoordModePrevious);
+ if (xfi->drw == xfi->backstore)
+ {
+
Example
You should change XFillPolygon calls
+ XFillPolygon(xfi->display, xfi->wnd, xfi->gc,
+ (XPoint *) point, npoints, Complex,
CoordModePrevious);
+ if (xfi->drw == xfi->backstore)
+ {
+
> Right but if the bug is on backstore it might affect the result. I
> think this is what Jay is interested in know.
I think I see a problem,
you are drawing to xfi->wnd instead of xfi->drw
Look at the other drawing functions.
You should only draw to xfi->wnd if (xfi->drw == xfi->backstore)
Jay
On Tue, Feb 15, 2011 at 19:05, eduardo fiss beloni
wrote:
> --- On Tue, 15/2/11, Jay Sorg wrote:
>> Do you test with --no-osb ?
...
> However, it has nothing to do with the polygon rendering as far as I can tell.
...
Right but if the bug is on backstore it might affect the result. I
think this i
--- On Tue, 15/2/11, Jay Sorg wrote:
> Do you test with --no-osb ?
> Interesting to see if that matters.
>
The --no-osb option is quite interesting because it give us a gain of
performance when rendering images (bitmaps) (according to my tests using the
PassMark benchmark).
However, it has
> Please be aware it is not a statement, it is just a clue... The point is I
> can't see anything going wrong in the polygon rendering functions, but the
> problem may be there... as well as somewhere else.
>
> It is worth another look.
Do you test with --no-osb ?
Interesting to see if that matt
--- On Mon, 14/2/11, Otavio Salvador wrote:
> > So I'm confused, does rdesktop have the same problem?
> ...
>
> No. rdesktop works.
>
That's it.
> What I meant is that rdesktop and freerdp code /seems/ to
> be doing the
> same thing. So *we* (Eduardo and I) think that the bug is
> on cache or
On Mon, Feb 14, 2011 at 21:42, Jay Sorg wrote:
...
> Otavio said rdesktop has the same problem but your screen shots show
> rdesktop working and freerdp not working.
> So I'm confused, does rdesktop have the same problem?
...
No. rdesktop works.
I failed to communicate what I meant. Let me try t
> Actually I've also got the ellipse implementation in a local branch. But I
> couldn't even test it yet...
>
> Sorry for having to send a message twice,
Maybe you can clear this up for me.
rdesktop has polygon and ellipse implemented for a couple of years.
Otavio said rdesktop has the same probl
--- On Mon, 14/2/11, eduardo fiss beloni wrote:
> No, I don't. I think for now, just comment the lines that
> turn on ellipse rendering would be enough. The actual
> ellipse drawing can be the next step after making polygon
> rendering to work properly.
>
Hello Jay
Actually I've also got the e
--- On Fri, 11/2/11, Jay Sorg wrote:
> The flag, polygon_ellipse_orders, turns on both polygon and
> ellipse ui
> calls but I only see polygon implemented.
> There is a printf on ellipse. Do you see it getting
> called?
>
No, I don't. I think for now, just comment the lines that turn on ellips
> Those screenshots illustrate the problem. Pay attention to the borders of the
> web pages...
The flag, polygon_ellipse_orders, turns on both polygon and ellipse ui
calls but I only see polygon implemented.
There is a printf on ellipse. Do you see it getting called?
Jay
--
On Thu, Feb 3, 2011 at 18:14, eduardo fiss beloni
wrote:
...
> I've found a little issue in those patches, thats why I couldn't push it: on
> win 7 and using IE, sometimes the browser borders get bogus (see screenshot).
>
> If you can please take a look and tell me if you have got any clue on thi
eerdp-devel] Polygon rendering cmd line option
> To: "eduardo fiss beloni"
> Cc: freerdp-devel@lists.sourceforge.net
> Date: Tuesday, January 25, 2011, 2:11 PM
> > I've been working in the
> function ui_polygon implementation which, together with this
> diff
&g
> I've been working in the function ui_polygon implementation which, together
> with this diff
>
> --- a/libfreerdp/capabilities.c
> +++ b/libfreerdp/capabilities.c
>
> - orderSupport[NEG_POLYGON_SC_INDEX] =
> (rdp->settings->polygon_ellipse_orders ? 1 : 0);
> - orderSupport[NEG_POLYG
16 matches
Mail list logo
