Re: [FreeRDP-devel] Set title before mapping

2018-11-17 Thread Henrique Martins via FreeRDP-devel
alexei> Well, that should be easy. bernhard> You could also just send a patch. I can create the PR. I've done this once before, 4 years ago. I had tried it before sending the patch to the list, but forgot the fork step. Just submitted a pull request, hopefully properly. -- Henrique

Re: [FreeRDP-devel] Set title before mapping

2018-11-17 Thread Bernhard Miklautz via FreeRDP-devel
Hi, On Fri, Nov 16, 2018 at 02:56:20PM -0800, Henrique Martins via FreeRDP-devel wrote: > > It does not depend on whether the window is mapped > > (visible) or not. So you can totally set the name before > > the window is made visible. > I know that. And it works, obviously. makes sense. Thank

Re: [FreeRDP-devel] Set title before mapping

2018-11-16 Thread Alexei Lozovsky via FreeRDP-devel
On Sat, 17 Nov 2018 at 00:56, Henrique Martins wrote: > I need to figure out how to do a pull request, though. > Well, that should be easy. Someone wrote a guide on git usage: https://github.com/freerdp/freerdp/wiki/Git-Version-Control After you make a branch with changes just follow

Re: [FreeRDP-devel] Set title before mapping

2018-11-16 Thread Henrique Martins via FreeRDP-devel
> It does not depend on whether the window is mapped > (visible) or not. So you can totally set the name before > the window is made visible. I know that. And it works, obviously. I need to figure out how to do a pull request, though. -- Henrique ___

Re: [FreeRDP-devel] Set title before mapping

2018-11-16 Thread Alexei Lozovsky via FreeRDP-devel
On Fri, 16 Nov 2018 at 18:19, Henrique Martins via FreeRDP-devel < freerdp-devel@lists.sourceforge.net> wrote: > In client/X11/xf_window.c, xf_CreateDesktopWindow, I'd like > the call to set the window title: > xf_SetWindowTitleText(xfc, window->handle, name); > to be done before mapping the

[FreeRDP-devel] Set title before mapping

2018-11-16 Thread Henrique Martins via FreeRDP-devel
In client/X11/xf_window.c, xf_CreateDesktopWindow, I'd like the call to set the window title: xf_SetWindowTitleText(xfc, window->handle, name); to be done before mapping the window with: XMapWindow(xfc->display, window->handle); (patch against master below). I use fvwm styles, triggered by