Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Brian West
Hold is working fine I just tested it... I would need to see the whole dialog to see what is wrong... I tested with Polycom, Snom and Aastra. Are you doing proxy media or anything like that? /b On Dec 29, 2009, at 1:14 AM, Lei Tang wrote: Hi, I think hold function in trunk 16055 is broken,

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Brian West
Also can you join #freeswitch-dev, include full siptrace+debug log and put it on pastebin. What phone are you using? /b On Dec 29, 2009, at 1:14 AM, Lei Tang wrote: Hi, I think hold function in trunk 16055 is broken, I have also tried some old trunks, it's ok in freeswitch 1.0.4. The

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Lei Tang
Hi Brian, thanks for your help, I am using FS in proxy media mode. the sip agent I'm using is x-lite and wxCommunicator. I will test if trunk 16055 work when I set proxy media mode to false tomorrow. 2009/12/29 Brian West br...@freeswitch.org Hold is working fine I just tested it... I would

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Lei Tang
The phone I'm using is x-lite and wxCommunicator, both are sip phone software. I have not used pastebin, Is it a bug trace tool like bugzilla? Can you tell me how to register a pastbin account? 2009/12/29 Brian West br...@freeswitch.org Also can you join #freeswitch-dev, include full

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Brian West
the 200ok is not from FS.. its from the end point... so its not us thats not putting the SDP into the 200ok but the device you're talking to because in proxy media they are passed as is. /b On Dec 29, 2009, at 8:53 AM, Lei Tang wrote: Hi Brian, thanks for your help, I am using FS in proxy

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Lei Tang
Hi Brian, I don't think so, I have debuged fs, If I'm not wrong, following code in sofia.c send the 200ok response sofia.c function sofia_handle_sip_i_state . switch(ss_state) case nua_callstate_received: .

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Lei Tang
Btw, in the same scenario, FS 1.0.4 works fine. 2009/12/29 Lei Tang lei.tl...@gmail.com Hi Brian, I don't think so, I have debuged fs, If I'm not wrong, following code in sofia.c send the 200ok response sofia.c function sofia_handle_sip_i_state . switch(ss_state)

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Michael Jerris
There is no need for you to show us traces. The fact that you are using proxy media is enough to know that the issue is with your device. If you look at the full sip trace you will see the same. Mike On Dec 29, 2009, at 10:10 AM, Lei Tang lei.tl...@gmail.com wrote: The phone I'm using

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Brian West
Its null because the device on the other side didn't send one. We pass it as is... fix the broken device or don't use proxy media. /b On Dec 29, 2009, at 9:37 AM, Lei Tang wrote: Hi Brian, I don't think so, I have debuged fs, If I'm not wrong, following code in sofia.c send the 200ok

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Michael Jerris
This means there was no sdp sent. Did you confirm this with siptrace? On Dec 29, 2009, at 10:37 AM, Lei Tang lei.tl...@gmail.com wrote: Hi Brian, I don't think so, I have debuged fs, If I'm not wrong, following code in sofia.c send the 200ok response sofia.c function

Re: [Freeswitch-users] Hold is broken in trunk 16055

2009-12-29 Thread Anthony Minessale
We now disable sofia SOA mode during proxy calls. This means that sofia will not try to get involved in the media negotiation at all which is the optimal behavior. Previous versions would butt in and try to fix the error but now it just stays out of the way. You can see in your trace that the