Re: Check return of function

2020-08-20 Thread Werner LEMBERG
>> Today the code is like this: >> >> error = FT_New_Size( t42face->ttf_face, ); >> t42size->ttsize = ttsize; >> FT_Activate_Size( ttsize ); >> >> My initial suggestion was: >> >> error = FT_New_Size( t42face->ttf_face, ); >> if(error) >> return error; >>

Re: Check return of function

2020-08-20 Thread Kleber Tarcísio
Hi Alexei, I'm not expert in this system, but I think that it is not a good pratice. Sorry if i caused any misunderstanding. Kleber Em quinta-feira, 20 de agosto de 2020 16:43:47 BRT, Alexei Podtelezhnikov escreveu: Kleber, Why would you prefer uninitialized t42size->ttsize to NULL?

Re: Check return of function

2020-08-20 Thread Alexei Podtelezhnikov
Kleber, Why would you prefer uninitialized t42size->ttsize to NULL? Please answer this question. Alexei On Thu, Aug 20, 2020 at 3:20 PM Kleber Tarcísio wrote: > > Hi everyone, > > I appreciate your attention! > > Today the code is like this: > > error = FT_New_Size( t42face->ttf_face,

Re: Check return of function

2020-08-20 Thread Kleber Tarcísio
Hi everyone, I appreciate your attention! Today the code is like this:    error = FT_New_Size( t42face->ttf_face, );    t42size->ttsize = ttsize;    FT_Activate_Size( ttsize );  My initial suggestion was:     error = FT_New_Size( t42face->ttf_face, );    if(error)    return error;

Re: Check return of function

2020-08-20 Thread Alexei Podtelezhnikov
> In the first case, I think we need return because ttsize can be NULL and > t42size->ttsize = ttsize; could get a NULL value.Is it a problem, no? > In the first case, I think we need return because ttslot can be NULL and > slot-> ttslot = ttslot; could get a NULL value.Is it a problem, no?

Gitlab Migration Progress

2020-08-20 Thread Anurag Thakur
Hey guys! So, I have almost completed the script for migration. Here is a Google drive link to see it in action(it's a video): https://drive.google.com/file/d/102TpqRiFv32PKkPLSASPasj5XCC71Ok1/view?usp=drivesdk Please go to gitlab.com/freetype2/issue-migration/issues/40 and tell me if any further

Re: Arial looks different in Win7 and Wine

2020-08-20 Thread Peter Grandi
> [ ...] So, as soon as I would use the original MS Arial font, > I would also have the original Microsoft glyph? Mostly, to be more precise you have the original Microsoft glyph *description*, this is rasterized by the glyph-renderer, different ones can result in slightly different glyphs. >

Re: Check return of function

2020-08-20 Thread Alexei Podtelezhnikov
Hi Kleber, > https://github.com/klebertarcisio/freetype2-1/commit/aab3c841f08c3a67914fbd0167ef4ff174116ccf What is wrong with a couple of housekeeping lines before returning the error? Why do you think that it is necessary to drop everything and run for cover? In fact, libraries are not supposed

Re: Arial looks different in Win7 and Wine

2020-08-20 Thread serando
Thank you very much for this detailed answer. 1) >It may look closer, or even identical if you also put under WINE a copy of the >original Microsoft glyph and text rendering DLLs, ... Do I understand right: The "original Microsoft glyph" is part of the original "MS font", not in any "dll".

Re: Arial looks different in Win7 and Wine

2020-08-20 Thread Peter Grandi
> This is very strange. I was expecting, that Wine Arial looks the same > like Windows Arial. I think that your expectations are very unrealistic because Arial is a proprietary font and cannot be distributed as free software. There is a 25 year old version of Arial that is part of the Microsoft

Re: Arial looks different in Win7 and Wine

2020-08-20 Thread Nikolay Sivov
On Thu, Aug 20, 2020 at 4:17 PM serando wrote: > Thank you. > > I have tried hard to find this false Arial. > > ... And I have found it. > > It's Wine Arial. Please have a look at the attachment. > > This is very strange. I was expecting, that Wine Arial looks the same > like Windows Arial. >

Check return of function

2020-08-20 Thread Kleber Tarcísio
Hi Free Type Team, how are you? My name is Kleber and I'm a PhD student. I'm working on a technique to help developers to find weaknesses in configurable systems. I would like to know what you think about this change:

Re: Migrate to github

2020-08-20 Thread Werner LEMBERG
[CCed to 'freetype-devel'] > Please check out > https://gitlab.com/freetype2/issue-migration/-/issues/27 and tell me > your suggestions. Very nice! Two comments. * Please replace Migrated from: [SAVANNAH-55235] reported by: rim with Migrated from: Savannah #55235 Reported by: