Re: [ft] FT_New_Face and PCF fonts

2013-09-25 Thread Akira TAGOH
Thanks for the fix. I'm looking forward to see that in a release :) On Wed, Sep 25, 2013 at 11:04 AM, suzuki toshiya mpsuz...@hiroshima-u.ac.jp wrote: Hi, Just I've committed, now PCF and BDF drivers return invalid argument error when non-zero face index is given. BTW, the argument checks

Re: [ft] FT_New_Face and PCF fonts

2013-09-24 Thread suzuki toshiya
Hi, Just I've committed, now PCF and BDF drivers return invalid argument error when non-zero face index is given. BTW, the argument checks are done AFTER the opening of the font file by each driver. Although I was going to change the drivers to refuse non-zero face index immediately without any

Re: [ft] FT_New_Face and PCF fonts

2013-09-24 Thread Werner LEMBERG
Just I've committed, now PCF and BDF drivers return invalid argument error when non-zero face index is given. Thanks! Werner ___ Freetype mailing list Freetype@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype

[ft] FT_New_Face and PCF fonts

2013-09-23 Thread Akira TAGOH
Hi, I just wonder why FT_New_Face() doesn't fail on PCF fonts when face_index is more than 0 even though it fails for OpenType fonts if it's more than FT_Face-num_faces. Is there any reasons why freetype behaves that way? -- Akira TAGOH ___ Freetype

Re: [ft] FT_New_Face and PCF fonts

2013-09-23 Thread suzuki toshiya
Hi, I could not find any record changing to allow such, from git commit log, so I guess it is unexpected/overlooked behaviour. I want to change it to return an error (invalid argument or something else?). Werner, more consideration is expected? Regards, mpsuzuki On 09/24/2013 11:45 AM, Akira

Re: [ft] FT_New_Face and PCF fonts

2013-09-23 Thread Werner LEMBERG
I could not find any record changing to allow such, from git commit log, so I guess it is unexpected/overlooked behaviour. I want to change it to return an error (invalid argument or something else?). Werner, more consideration is expected? Certainly a bug. Of course it should return