Re: [ft-devel] Variable fonts: hhea/typo/win metrics interpreted differently for instances compared to static fonts?

2019-01-27 Thread Nikolaus Waxweiler
After doing some vanilla/patch switching of FreeType and testing, I found that Chromium is indeed impacted by the patch. Without it, switching between the VFs I attached to https://gitlab.gnome.org/GNOME/gtk/issues/1626 makes no difference on http://www.cyreal.org/Font-Testing-Page/index.php

Re: [ft-devel] Variable fonts: hhea/typo/win metrics interpreted differently for instances compared to static fonts?

2019-01-27 Thread Nikolaus Waxweiler
Actually, Behdad, just so I understand correctly: In the case of Cantarell, assuming the line gap is put at the top, toggling USE_TYPO_METRICS should _in theory_ not make any difference because each of hhea, typo and win sums up to a total height of 1200 font units (1000 upM font + 20% line

Re: [ft-devel] Variable fonts: hhea/typo/win metrics interpreted differently for instances compared to static fonts?

2019-01-27 Thread Nikolaus Waxweiler
Oh, right, sorry :D So after some weeks of testing, I can say that fonts that set the USE_TYPO_METRICS bit and have a sTypoLineHeight set to non-zero consistently look shifted up in GNOME, so this patch seems to work ;) No eye-catching change in Qt UI, Chromium or Firefox. Will test some