Re: [ft-devel] [patch] fuller right margin in ftview

2012-07-03 Thread Werner LEMBERG
The attached patch returns the error code 0xFF when the margin is crossed and leaves 3 pixels blank at the right margin. I've just tested it, and it fails for fonts which can't be emboldened (for example, BDF). Besides that, it looks OK. Werner inline:

Re: [ft-devel] [patch] fuller right margin in ftview

2012-07-03 Thread Alexei Podtelezhnikov
On Tue, Jul 3, 2012 at 6:08 PM, Werner LEMBERG w...@gnu.org wrote: The attached patch returns the error code 0xFF when the margin is crossed and leaves 3 pixels blank at the right margin. I've just tested it, and it fails for fonts which can't be emboldened (for example, BDF). Besides that,

Re: [ft-devel] [patch] fuller right margin in ftview

2012-07-01 Thread Alexei Podtelezhnikov
On Wed, Jun 27, 2012 at 1:22 PM, Werner LEMBERG w...@gnu.org wrote: [...] the drawing functions ultimately inherit the error codes from FT_Glyph_To_Bitmap currently. Therefore it has to be something different from those defined in fterrdef.h to distinguish. It would be good if freetype

Re: [ft-devel] [patch] fuller right margin in ftview

2012-06-27 Thread Werner LEMBERG
The attached patch changes the way 'ftview' fills the window with glyphs so that the right margin is less blank and a larger number of glyphs shown. It uses the actual width of the current grBitmap, instead of super conservative max_advance, when fitting the glyphs in the available space.

Re: [ft-devel] [patch] fuller right margin in ftview

2012-06-27 Thread Alexei Podtelezhnikov
The attached patch changes the way 'ftview' fills the window with glyphs so that the right margin is less blank and a larger number of glyphs shown. It uses the actual width of the current grBitmap, instead of super conservative max_advance, when fitting the glyphs in the available space.

Re: [ft-devel] [patch] fuller right margin in ftview

2012-06-27 Thread Werner LEMBERG
I've picked FT_Err_Raster_Overflow to indicate the boundary. Is that appropriate? No, it isn't IMHO: FT_Err_Raster_Overflow is a fatal error, indicating a serious problem which the rasterizer can't manage. I think a simple integer will serve as return error instead of FT_Error. I am also

Re: [ft-devel] [patch] fuller right margin in ftview

2012-06-27 Thread Alexei Podtelezhnikov
On Wed, Jun 27, 2012 at 8:33 AM, Werner LEMBERG w...@gnu.org wrote: I've picked FT_Err_Raster_Overflow to indicate the boundary.  Is that appropriate? No, it isn't IMHO: FT_Err_Raster_Overflow is a fatal error, indicating a serious problem which the rasterizer can't manage.  I think a simple

Re: [ft-devel] [patch] fuller right margin in ftview

2012-06-27 Thread Werner LEMBERG
[...] the drawing functions ultimately inherit the error codes from FT_Glyph_To_Bitmap currently. Therefore it has to be something different from those defined in fterrdef.h to distinguish. It would be good if freetype reserved an FT_Err_User, defined as -1 or 0xFF perhaps, which is not

[ft-devel] [patch] fuller right margin in ftview

2012-06-22 Thread Alexei Podtelezhnikov
In memory of Paul Alexi Hi all, The attached patch changes the way 'ftview' fills the window with glyphs so that the right margin is less blank and a larger number of glyphs shown. It uses the actual width of the current grBitmap, instead of super