Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Werner LEMBERG
> I think the enumeration values should be FT_DIAGNOSTIC_XXX too. > Sometimes it's a good idea to spell things out. This is fine with me. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/f

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Werner LEMBERG
>> Do people still care about restricting to the convention of 8.3 >> file names? > > Not this century. Wll... I like consistency, so I prefer `ftdiag.h' – people would include this as `FT_DIAGNOSTICS_H' anyway. BTW, instead of using `diagnose' we could base the used names on `validate'; t

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Werner LEMBERG
> I'd likely just use your patch instead, when I do the win32/64 and > mac os x binaries in the next couple of days. This is just a suggestion, so please massage it as needed! > I thought about the enum vs string issue (FT_DIAG_XXX) a bit, as I > mentioned at the beginning - the problem I am fac

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Hin-Tak Leung
On Wed, 6/7/16, Graham Asher wrote: > Please consider calling it ftdiagnostics.h, which is more explanatory. To my native-English-speaking mind, 'diag' looks as if it stands for 'diagonal' or 'diagram'. On the subject of ad

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Graham Asher
Not this century. On 06/07/2016 10:37, Hin-Tak Leung wrote: Do people still care about restricting to the convention of 8.3 file names? -- Graham Asher founder and CTO CartoType Ltd graham.as...@cartotype.com +44 (0) 7718 895191 ___ Freetype-devel ma

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Hin-Tak Leung
Thanks for reviewing and revising the patch. I'd likely just use your patch instead, when I do the win32/64 and mac os x binaries in the next couple of days. Right now I still have a few things to do on the C# side. I thought about the enum vs string issue (FT_DIAG_XXX) a bit, as I mentioned at

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Graham Asher
Please consider calling it ftdiagnostics.h, which is more explanatory. To my native-English-speaking mind, 'diag' looks as if it stands for 'diagonal' or 'diagram'. I think the enumeration values should be FT_DIAGNOSTIC_XXX too. Sometimes it's a good idea to spell things out. - Graham On 06

Re: [ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics

2016-07-06 Thread Werner LEMBERG
> Here is the updated patch for 2.6.4 - there are some minor > collisions with the new subpixel hinting mode. Attached is something that would fit better into FreeType w.r.t. formatting, macro definitions, and function names. I suggest to provide a public header file `ftdiag.h' that defines, sim

[ft-devel] updated patch for 2.6.4 Re: proposed patch for diagnostics (Re: implementing detection of hinting/rasterization errors in fonts)

2016-07-05 Thread Hin-Tak Leung
Here is the updated patch for 2.6.4 - there are some minor collisions with the new subpixel hinting mode. while updating the diff I looked into the global variable issue. Putting the diagnostic messaging pointer inside TT_Face is fairly straight forward, and it isn't too hard to do it per TT_F