El divendres, 1 de maig de 2020, a les 0:52:16 CEST, David Turner va escriure:
> Le jeu. 30 avr. 2020 à 23:33, Albert Astals Cid a écrit :
>
> > El dijous, 30 d’abril de 2020, a les 19:35:19 CEST, Behdad Esfahbod va
> > escriure:
> > > Hi David,
> > >
> > > Thanks for bringing this up. I come
> Here are two cumulative patches that try to simplify the rules.mk
> and module.mk used by the FreeType 2 build system. [...]
Thanks a lot, will check them soon!
Since I'm going to cut a new release soon I wonder whether it makes
sense to put this patch temporarily into a branch, avoiding
Yes, none of that is urgent :) Feel free to not push them to master for now
(branch or no branch).
I'd still value your input on the content though, hope it's not too scary :)
Le ven. 1 mai 2020 à 10:25, Werner LEMBERG a écrit :
>
> > Here are two cumulative patches that try to simplify the
Le ven. 1 mai 2020 à 10:12, Albert Astals Cid a écrit :
>
>
> I apologize if somebody felt personally wronged by my comment.
>
> Since I don't see anything wrong with it, I would be very happy if you
> could please explain what's wrong with it so I can try to improve myself in
> the future.
>
>
This patches removes a few compiler warnings when building the FreeType 2
demo programs.
It also replaces a few strncpy() calls with snprintf() for safety /
simplicity.
This should fix https://savannah.nongnu.org/bugs/?58275
From 33ebbd7333d10a5dbac6cac9c37c95a573e24e80 Mon Sep 17 00:00:00 2001
> [...] I'm interested in the decision under a situation: if harfbuzz
> requires libstdc++, should we care the dependency of FreeType?
Please elaborate. Given that FreeType is a C library it's not clear
to me why there should be an issue – FreeType happily works without
HarfBuzz (then with
> This should fix https://savannah.nongnu.org/bugs/?58275
> <0001-Fix-compilation-warnings.patch>
We still use Emacs style for commit messages and track them in ChangeLog, which
is debatable
Le ven. 1 mai 2020 à 13:53, Alexei Podtelezhnikov a
écrit :
>
> This should fix https://savannah.nongnu.org/bugs/?58275
>
> <0001-Fix-compilation-warnings.patch>
>
>
> We still use Emacs style for commit messages
>
I'm not sure what that means. I've updated the commit message to look like
what
>> We still use Emacs style for commit messages
>
> I'm not sure what that means. I've updated the commit message to
> look like what is currently in the git log.
He means that we still maintain a ChangeLog file.
>> and track them in ChangeLog, which is debatable
>
> Yes, it seems a bit
> This patches removes a few compiler warnings when building the
> FreeType 2 demo programs. It also replaces a few strncpy() calls
> with snprintf() for safety / simplicity.
Thanks a lot! Now committed.
Werner
> > Yes, it seems a bit odd these days, but I'll let Werner be the judge
> > on that :-)
>
> The main reason to maintain a ChangeLog file in the strict Emacs-like
> format is that you have to concentrate on adding good descriptions.
> Writing a sloppy one-liner while doing `git commit` is far too
>
> I apologize if somebody felt personally wronged by my comment.
>
> Since I don't see anything wrong with it, I would be very happy if you could
> please explain what's wrong with it so I can try to improve myself in the
> future.
Rather easy. I am sure this is not how you communicate with
There are tools like towncrier and probably others where your patches are
accompanied by news fragments in a news dir that are assembled into a news
file and then cleared on release.
13 matches
Mail list logo
