Re: [ft-devel] [PATCH] Improve FT_MulFix

2011-04-05 Thread Werner LEMBERG
>> WL> Please redo the patch so that the old code gets saved within a #if 0 >> WL> ... #endif clause (to stay as a reference), >> >> (having the old code in the repo’s history is not enough? :^) > > I agree with James. Disabled code only clutters the code base... In most circumstances, I fully

Re: [ft-devel] [PATCH] Improve FT_MulFix

2011-04-05 Thread Behdad Esfahbod
On 04/05/11 17:04, James Cloos wrote: > WL> Looks good, thanks! > > WL> Please redo the patch so that the old code gets saved within a #if 0 > WL> ... #endif clause (to stay as a reference), > > (having the old code in the repo’s history is not enough? :^) I agree with James. Disabled code onl

Re: [ft-devel] [PATCH] Improve FT_MulFix

2011-04-05 Thread James Cloos
> "WL" == Werner LEMBERG writes: WL> Looks good, thanks! WL> Please redo the patch so that the old code gets saved within a #if 0 WL> ... #endif clause (to stay as a reference), (having the old code in the repo’s history is not enough? :^) WL> and add a comment to the new code (essentiall

Re: [ft-devel] [PATCH] Improve FT_MulFix

2011-04-05 Thread Werner LEMBERG
> Please consider pulling the master branch of: > > git://anongit.freedesktop.org/~cloos/freetype2.git > > to receive the patch below. Looks good, thanks! Please redo the patch so that the old code gets saved within a #if 0 ... #endif clause (to stay as a reference), and add a comment to the ne