Re: ftbench: last updates

2023-09-25 Thread Werner LEMBERG

> I hope my effort contribute to you. I wish to see you again.

:-) You are invited to continue your work even after GSoC has ended.

> Here is my last version of readme, [...]

Uh, oh, the formatting in the e-mail is completely broken...

> i will push submit my final submission regarding your feedback.

Ideally, you apply formatting and indenting changes to, say, the
fourth commit from the top (within your branch) by doing the
following:

```
git rebase -i HEAD   # interactive rebase


git add -p   # add diffs one by one
git commit --amend   # rewrite current commit
git rebase --continue# continue rebase
git push -f  # force-push
```

Currently, there is a bunch of whitespace commits on top of the
cleaned-up commits.  However, the idea of a cleaned-up tree is that
such formatting changes are *not* present – please bear in mind that
we don't squash the commits into a single one!

I would be glad if you could remove the whitespace commits and include
the whitespace fixes in the actual commits instead (don't worry about
today's GSoC deadline, this is cosmetics only).

> (also waiting for *-demos code review, i will push them too)

Thanks.


Werner


Re: ftbench: last updates

2023-09-25 Thread Ahmet Göksu
Thanks a lot :)

I hope my effort contribute to you. I wish to see you again.
Here is my last version of readme, i will push submit my final submission 
regarding your feedback. (also waiting for *-demos code review, i will push 
them too)
>
>
> ftbench
> ftbench is a program designed to run FreeType benchmarks between versions.It 
> accepts various options to run specific tests on font rendering operations.
> Each test may involve tasks such as:
> . Initializing the library. Opening the font file. Comparing results with 
> cached versions (if available). Configuring specific charmap indices, load 
> flags, etc.
> Usage is iterations-limited or can be explicitly set to use a maximumnumber 
> of iterations per test.
>
> Command line options
> -C      Compare with cached version (if available).-c N    Use at most N 
> iterations for each test (0 means time-limited).-e E    Set specific charmap 
> index E.-f L    Use hex number L as load flags (see FT_LOAD_XXX').-H NAME  
> Use PS hinting engine NAME (default is adobe').-I VER  Use TT interpreter 
> version VER (default is version 40).-i I-J  Forward or reverse range of glyph 
> indices to use.-l N    Set LCD filter to N (default is 0: none).-m M    Set 
> maximum cache size to M KiByte (default is 1024).-p      Preload font file in 
> memory.-r N    Set render mode to N (default is 0: normal).-s S    Use S ppem 
> as face size (default is 10ppem).-t T    Use at most T seconds per bench 
> (default is 2).-w N    Use N iterations for warming up before each test.
> -b      tests Perform chosen tests (default is all).-v      Show version.
> Usage---
> make baseline    To create a baseline for your benchmarks,use the 
> `make baseline` command.  This will compile the ftbench.c andcreate a set of 
> baseline measurements in the objs/baseline/ directory.
> make benchmark   To run the benchmarks, use the `make benchmark` 
> command.The results will be stored in the objs/benchmark/ directory.It will 
> copy tohtml.py script to objs/ and generate a html file.
> make clean-benchmark    To remove all generated benchmark files andclean the 
> objs directory, use the `make clean-benchmark` command.
>

Best,
Goksu
goksu.in
On 25 Sep 2023 07:20 +0300, Werner LEMBERG , wrote:
>
> Hello Ahmet,
>
>
> sorry for the late reply, I'm travelling right now.
>
> > -Made documentation and comment line (will continue).
>
> Very nice! Some minor nits, in case you have still time today:
>
> * Please ensure that lines in the documentation are not longer than 78
> characters (`src/tools/ftbench/README`). Ideally, `README` comes in
> Markdown format, but this is not important.
>
> * Use two spaces after a full dot in documentation (this simplifies
> the search for the beginning of a sentence with some editors like
> Emacs).
>
> * Use `autopep8 -a -a -a` to format `tohtml.py` and do some manual
> editing to also shorten the remaining overlong lines to
> 78 characters per line if possible and useful.
>
> * There are some indentation errors in `ftbench.c` (functions
> `test_render`, `test_embolden`, etc.).
>
> * Please synchronize `ftbench.c` with the git version in the
> `freetype-devel` repository (which is a trivial change only).
>
> > In this version of the code, i just didnt splitted iterations into
> > chunks, got same results with it.
>
> OK. Too bad that we couldn't find the real cause for the large time
> differences, but hey, this is a GSoC project :-)
>
>
> Werner