Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-30 Thread Werner LEMBERG
> > gray2 and gray4 are not supported now. I'll see if I can add > > support to them. If I can't, I'll submit a patch to update the > > documentation :) > > Ok, this patch should fix the problem. Indeed, it does. Thanks again for your efforts. I've applied your patch. Werner __

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-30 Thread Chia I Wu
On Mon, May 30, 2005 at 03:24:30PM +0800, Chia I Wu wrote: > gray2 and gray4 are not supported now. I'll see if I can add support to them. > If I can't, I'll submit a patch to update the documentation :) Ok, this patch should fix the problem. Instead of supporting gray[24] directly, convertion fr

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-30 Thread Chia I Wu
On Mon, May 30, 2005 at 08:26:44AM +0200, Werner LEMBERG wrote: > > > This is introduced by the last patch :( > > Hehe, there still seem to be problems :-) The glyphs in the two > attached fonts don't change at all (neither the appearance nor the > advance width) if I check embolding with ftview

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-30 Thread Werner LEMBERG
> I've dirty hacked ftview for testing bitmap emboldening of various > pixel_mode. You can find the hack in the attachments. OK, I won't apply it right now. Maybe you find time to polish your code... Werner ___ Freetype-devel mailing list Free

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-29 Thread Werner LEMBERG
> Oops, I forgot to adjust emboldening strength in the last ftsynth.c > patch. Please ignore that one. I've applied your patches, thanks. Please test whether everything is fine. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org h

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-29 Thread Werner LEMBERG
> This is introduced by the last patch :( Hehe, there still seem to be problems :-) The glyphs in the two attached fonts don't change at all (neither the appearance nor the advance width) if I check embolding with ftview (not using your patch). Werner STARTFONT 2.1 COMMENT "Anti-aliased tes

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-29 Thread Chia I Wu
On Sat, May 28, 2005 at 03:47:49PM +0200, Werner LEMBERG wrote: > > > This patch fixes some bugs in FT_Bitmap_Embolden. > > Applied, thanks. I think there is still a bug for graymap fonts. > Have a look at the attached test glyph. Emboldening produces a > strange result. Oops, I forgot to adjus

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-29 Thread Chia I Wu
On Sat, May 28, 2005 at 03:47:49PM +0200, Werner LEMBERG wrote: > > > This patch fixes some bugs in FT_Bitmap_Embolden. > > Applied, thanks. I think there is still a bug for graymap fonts. > Have a look at the attached test glyph. Emboldening produces a > strange result. This is introduced by t

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-28 Thread Werner LEMBERG
> This patch fixes some bugs in FT_Bitmap_Embolden. Applied, thanks. I think there is still a bug for graymap fonts. Have a look at the attached test glyph. Emboldening produces a strange result. Werner STARTFONT 2.1 COMMENT "Anti-aliased test font." COMMENT "It uses the BDF of Mark Leish

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-27 Thread Chia I Wu
On Wed, May 25, 2005 at 07:50:16AM +0200, Werner LEMBERG wrote: > > Thanks, applied! Note that I've changed the third and fourth argument > of FT_Bitmap_Embolden to be normal values, not pointers. Please test. > > > Werner Hi Werner, This patch fixes some bugs in FT_Bitmap_Embolden. Cha

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-26 Thread Werner LEMBERG
> There is one stupid bug in the last patch. Please apply this one. Applied, thanks. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-26 Thread Werner LEMBERG
> > [...] you can see that the glyphs get fatter and fatter. > Thanks for testing. The attached patch should fix the problem. Applied, 謝謝你. > (Changelog entry included. You may need to change the date.) It's better to include the ChangeLog entry in the mail instead of the patch. In case someone

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-26 Thread Chia I Wu
On Thu, May 26, 2005 at 05:25:33PM +0800, Chia I Wu wrote: > On Thu, May 26, 2005 at 07:32:49AM +0200, Werner LEMBERG wrote: > > Anyway, there is a bug, either in your emboldening code or in ftview. > > Load the attached font with > > > > ftview 15 Chicago.12.bdf > > > > then press the space ke

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-26 Thread Chia I Wu
On Thu, May 26, 2005 at 07:32:49AM +0200, Werner LEMBERG wrote: > Anyway, there is a bug, either in your emboldening code or in ftview. > Load the attached font with > > ftview 15 Chicago.12.bdf > > then press the space key, arrow up, arrow down, arrow up, arrow down, > etc., and you can see th

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-25 Thread Werner LEMBERG
> I tried to make this patch elegant, but, well, ftview.c needs > refactoring. Thanks a lot! It's now in the CVS. And a special thank you to you for obeying or strange formatting rules :-) Anyway, there is a bug, either in your emboldening code or in ftview. Load the attached font with ftvi

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-25 Thread Chia I Wu
On Wed, May 25, 2005 at 07:54:56AM +0200, Werner LEMBERG wrote: > > > > I'm unfamiliar with this API and never checked the bolden result > > > in detail, could you show some demo program? > > > > I've made a quick hack to ftview.c for demo. See applied patch. > > Can you update this patch too, pl

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-24 Thread Werner LEMBERG
> > I'm unfamiliar with this API and never checked the bolden result > > in detail, could you show some demo program? > > I've made a quick hack to ftview.c for demo. See applied patch. Can you update this patch too, please? This is, add emboldening to the rendering mode cycle. Werner __

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-24 Thread Werner LEMBERG
> This patch implements FT_Bitmap_Embolden and FT_Outline_Embolden. > It is intended for testing the algorithm and for discussing what > arguments should these function calls take. Since David has fixed the problem (and rejected your modifications because of too great distortions under some circu

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-21 Thread Chia I Wu
Hi all, This patch implements FT_Bitmap_Embolden and FT_Outline_Embolden. It is intended for testing the algorithm and for discussing what arguments should these function calls take. Both function calls are documented, and you can read them directly in the patch. I also make FT_GlyphSlot_Embolden

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-21 Thread Werner LEMBERG
> Maybe that's not something FreeType library should care, but some > programs that requires precise positioning of glyphs may not want > glyph metrics to be modified in uncontrollable manner. And I think > keeping full-width always to be full-width is the best way for CJK. I fully agree.

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-20 Thread Shunsaku Hirata
> > >I think glyph metrics should be changed automagically. > > > > Umm, yes, so, when fixed-width font is embolded, the result can be > > proportional? I think there are many X applications (terminal emulators > > and curses applications may be typical examples) which assumes/expects > > the Hanzi

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-20 Thread Chia I Wu
On Fri, May 20, 2005 at 06:15:15AM +0200, Werner LEMBERG wrote: > > > > > As fontconfig and xft already have the code to "embolden" and > > > > rely on FT_GlyphSlot_Embolden to do the real job, I think > > > > FT_GlyphSlot_Embolden should be made standard API. This is an > > > > important feature

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-14 Thread Chia I Wu
On Fri, May 13, 2005 at 07:51:12AM +0200, Werner LEMBERG wrote: > > > As fontconfig and xft already have the code to "embolden" and rely > > on FT_GlyphSlot_Embolden to do the real job, I think > > FT_GlyphSlot_Embolden should be made standard API. This is an > > important feature for Chinese (ma

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-14 Thread Werner LEMBERG
> Considering there is such root of embolding request, I wonder > whether FT_GlyphSlot_Embolden() API is already enough for the > purpose. It does not receive much parameters to control embolding > (am I misunderstanding?). I'm afraid several control parameters are > requested in future, for exa

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-14 Thread Werner LEMBERG
> As fontconfig and xft already have the code to "embolden" and rely > on FT_GlyphSlot_Embolden to do the real job, I think > FT_GlyphSlot_Embolden should be made standard API. This is an > important feature for Chinese (maybe also Japanese and Korean) > users, as most Chinese fonts don't have a

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-13 Thread Chia I Wu
On Fri, May 13, 2005 at 05:33:54PM +0900, [EMAIL PROTECTED] wrote: > >> * switch to enable/disable changing glyph metrics in embolding > >> * switch to enable/disable embolding of bitmap font > >I think glyph metrics should be changed automagically. > > Umm, yes, so, when fixed-width font is embol

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-13 Thread mpsuzuki
On Fri, 13 May 2005 14:52:24 +0800 Chia I Wu <[EMAIL PROTECTED]> wrote: >On Fri, May 13, 2005 at 11:44:59AM +0900, [EMAIL PROTECTED] wrote: >> I'm unfamiliar with this API and never checked the bolden result in >> detail, could you show some demo program? >I've made a quick hack to ftview.c for de

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-12 Thread Chia I Wu
On Fri, May 13, 2005 at 11:44:59AM +0900, [EMAIL PROTECTED] wrote: > Hi > > On Thu, 12 May 2005 23:44:11 +0800 > Chia I Wu <[EMAIL PROTECTED]> wrote: > >As fontconfig and xft already have the code to "embolden" and rely on > >FT_GlyphSlot_Embolden to do the real job, I think FT_GlyphSlot_Embolden

Re: [ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-12 Thread mpsuzuki
Hi On Thu, 12 May 2005 23:44:11 +0800 Chia I Wu <[EMAIL PROTECTED]> wrote: >As fontconfig and xft already have the code to "embolden" and rely on >FT_GlyphSlot_Embolden to do the real job, I think FT_GlyphSlot_Embolden >should be made standard API. This is an important feature for Chinese >(maybe

[ft-devel] Make FT_GlyphSlot_Embolden standard API?

2005-05-12 Thread Chia I Wu
Hi all, As fontconfig and xft already have the code to "embolden" and rely on FT_GlyphSlot_Embolden to do the real job, I think FT_GlyphSlot_Embolden should be made standard API. This is an important feature for Chinese (maybe also Japanese and Korean) users, as most Chinese fonts don't have a rea