Re: [ft-devel] comments on GF driver

2018-08-12 Thread Parth Wazurkar
> > > please test on the `cleaned' branch I have mostly fixed all the > > bugs, please check there now, I did not push changes to the `wip' > > branch. > > OK, will do, perhaps tomorrow morning. Now I'm going to watch the > Perseid meteor shower :-) > No problem :-) Btw, I have mostly fixed all

Re: [ft-devel] comments on GF driver

2018-08-12 Thread Werner LEMBERG
> please test on the `cleaned' branch I have mostly fixed all the > bugs, please check there now, I did not push changes to the `wip' > branch. OK, will do, perhaps tomorrow morning. Now I'm going to watch the Perseid meteor shower :-) Werner

Re: [ft-devel] comments on GF driver

2018-08-12 Thread Parth Wazurkar
> > * A missing TFM module is not a reason to abort loading of the GF > file, cf. line 222 in `gfdrivr.c'. Or is it? Does loading a plain > GF file (without a TFM file) needs code from the TFM module? > Yes, it is needed as we have not defined a macro like `T1_CONFIG_OPTION_NO_AFM' for the

Re: [ft-devel] comments on GF driver

2018-08-12 Thread Werner LEMBERG
[Now testing `wip' branch, commit b064189c9] > while debugging your code I've observed some issues. Here the next bunch of comments. There is so much still to do... * The code to compute `encoding' in function `gf_set_encodings' looks overly complicated. I don't think you need two nested

Re: [ft-devel] comments on GF driver

2018-08-12 Thread Parth Wazurkar
> > [Now testing `wip' branch, commit b064189c9] > > > while debugging your code I've observed some issues. > > Here the next bunch of comments. There is so much still to do... > > * The code to compute `encoding' in function `gf_set_encodings' looks > overly complicated. I don't think you

[ft-devel] comments on GF driver

2018-08-12 Thread Werner LEMBERG
[git commit 743b415ca95ad25722a2fb260920cfab21220479] Parth, while debugging your code I've observed some issues. * A missing TFM module is not a reason to abort loading of the GF file, cf. line 222 in `gfdrivr.c'. Or is it? Does loading a plain GF file (without a TFM file) needs code