Re: [ft-devel] failed to compile ftvalid.c

2005-11-18 Thread mpsuzuki
On Fri, 18 Nov 2005 08:19:40 +0100 (CET) Werner LEMBERG <[EMAIL PROTECTED]> wrote: >> I attached 4 patches, please check. > >And please install! Just I've committed 4 patches. Thanks to all for helpful comments! Regards, mpsuzuki ___ Freetype-devel ma

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Werner LEMBERG
> I attached 4 patches, please check. And please install! Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Werner LEMBERG
> I attached 4 patches, please check. Thanks a lot! > I wrote FT_TrueTypeGX_Free() to receive FT_Face (to identify the > memory object) and FT_Bytes to free, but it is possible to receive > FT_Memory instead of FT_Face. Any recommendation? Since most functions of FreeType take FT_Face, I think

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Masatake YAMATO
> I wrote FT_TrueTypeGX_Free() to receive FT_Face (to > identify the memory object) and FT_Bytes to free, > but it is possible to receive FT_Memory instead of > FT_Face. Any recommendation? Passing the face is better because memory is private: typedef struct FT_FaceRec_ { FT_Long

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread mpsuzuki
Dear Sirs, On Fri, 18 Nov 2005 10:05:32 +0900 [EMAIL PROTECTED] wrote: >OK, I will do that. Give me 6 hours. I attached 4 patches, please check. freetype2_fix-FT_FREE_GX.patch: add FT_TrueTypeGX_Free() and FT_ClassicKern_Free() freetype2_fix-FT_FREE_OT.patch add FT_OpenType_Free(

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread mpsuzuki
On Thu, 17 Nov 2005 20:48:05 +0100 (CET) Werner LEMBERG <[EMAIL PROTECTED]> wrote: >> I suggest exporting another function, which simply calls FT_FREE, to >> free the tables. > >Yes, David suggests the same. > >Toshiya or Masatake, do you have time to implement proper functions, >say, FT_TrueTypeG

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Werner LEMBERG
> I suggest exporting another function, which simply calls FT_FREE, to > free the tables. Yes, David suggests the same. Toshiya or Masatake, do you have time to implement proper functions, say, FT_TrueTypeGX_Validate_Free, which do the obvious? Maybe you find better function names. Werner

RE: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Turner, David
> > You should use free() in ftvalid.c because FT_FREE() is not a public > API. > First of all, the code within FreeType should *never* use 'free' or 'malloc' directly. The font engine can be compiled in environments where these functions are not available. Your problem is that the public API of

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread mpsuzuki
On Thu, 17 Nov 2005 17:04:43 +0800 Chia-I Wu <[EMAIL PROTECTED]> wrote: >$ nm -a objs/.libs/libfreetype.so | grep Free_Debug >6cb8 t FT_Free_Debug >$ nm -D objs/.libs/libfreetype.so | grep Free_Debug >(gives nothing) >$ nm --version >GNU nm 2.16.91 20050902 Debian GNU/Linux Thanks, I think, t

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Chia-I Wu
On Thu, Nov 17, 2005 at 03:47:38PM +0900, [EMAIL PROTECTED] wrote: > Hi, > > On Thu, 17 Nov 2005 11:46:09 +0900 > [EMAIL PROTECTED] wrote: > Excuse me, you received this error in compiling ftvalid.c > into ftvalid.o? Or, you received it in linking ftvalid.o > to ftvalid executable? It's in linking

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread Werner LEMBERG
> >In otvalid, documents say `free' should be used. > > I see. The usage of FT_ALLOC() and FT_FREE() is very same between > otvalid and gxvalid. Yet I'm not sure the reason why free() should > be used for tools using otvalid, You should use free() in ftvalid.c because FT_FREE() is not a public AP

Re: [ft-devel] failed to compile ftvalid.c

2005-11-17 Thread mpsuzuki
On Thu, 17 Nov 2005 16:04:45 +0900 (JST) Masatake YAMATO <[EMAIL PROTECTED]> wrote: >>>FT_Free_Debug is called indirectly by FT_FREE to free various tables, >>>which is no longer public. (and freetype reports leaks when use `free' >>>, not FT_FREE, to free these tables) > >mpsuzuki, I don't have t

Re: [ft-devel] failed to compile ftvalid.c

2005-11-16 Thread Masatake YAMATO
> >When compiling ftvalid.c, I get this error: > > > >ft2demos/obj/ftvalid.o: In function `run_ot_validator': > >ft2demos/src/ftvalid.c:447: undefined reference to `FT_Free_Debug' > >ft2demos/obj/ftvalid.o: In function `run_gx_validator': > >ft2demos/src/ftvalid.c:498: undefined reference to `FT_Fr

Re: [ft-devel] failed to compile ftvalid.c

2005-11-16 Thread mpsuzuki
Hi, On Thu, 17 Nov 2005 11:46:09 +0900 [EMAIL PROTECTED] wrote: >>ft2demos/obj/ftvalid.o: In function `run_ot_validator': >>ft2demos/src/ftvalid.c:447: undefined reference to `FT_Free_Debug' >>ft2demos/obj/ftvalid.o: In function `run_gx_validator': >>ft2demos/src/ftvalid.c:498: undefined referenc

Re: [ft-devel] failed to compile ftvalid.c

2005-11-16 Thread mpsuzuki
Hi On Thu, 17 Nov 2005 10:36:00 +0800 Chia-I Wu <[EMAIL PROTECTED]> wrote: >When compiling ftvalid.c, I get this error: > >ft2demos/obj/ftvalid.o: In function `run_ot_validator': >ft2demos/src/ftvalid.c:447: undefined reference to `FT_Free_Debug' >ft2demos/obj/ftvalid.o: In function `run_gx_valida

[ft-devel] failed to compile ftvalid.c

2005-11-16 Thread Chia-I Wu
Hi, When compiling ftvalid.c, I get this error: ft2demos/obj/ftvalid.o: In function `run_ot_validator': ft2demos/src/ftvalid.c:447: undefined reference to `FT_Free_Debug' ft2demos/obj/ftvalid.o: In function `run_gx_validator': ft2demos/src/ftvalid.c:498: undefined reference to `FT_Free_Debug' ft2