Re: [ft-devel] [patch] streamline pcf_get_encodings

2013-02-01 Thread Werner LEMBERG

>> The attached patch simplifies 'pcf_get_encodings'. By switching
>> from a single loop to a double loop, it simplifies a crazy
>> expression for the enc field. It also utilizes FT_RENEW_ARRAY
>> instead of copying the content over from a temporary array. So, I'd
>> like to commit it, but PCF fonts with encodings are not heavily
>> used these days. Please review. How would I test it?
> 
> I've committed the patch after testing with ftstring using English,
> Russian and Chinese text.

Thanks!  Will have a look soon, and sorry for not being responsive
earlier.


Werner

___
Freetype-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/freetype-devel


Re: [ft-devel] [patch] streamline pcf_get_encodings

2013-02-01 Thread Alexei Podtelezhnikov
On Tue, Jan 29, 2013 at 8:25 AM, Alexei Podtelezhnikov
 wrote:
> The attached patch simplifies 'pcf_get_encodings'. By switching from a
> single loop to a double loop, it simplifies a crazy expression for the
> enc field. It also utilizes FT_RENEW_ARRAY instead of copying the
> content over from a temporary array. So, I'd like to commit it, but
> PCF fonts with encodings are not heavily used these days. Please
> review. How would I test it?

I've committed the patch after testing with ftstring using English,
Russian and Chinese text.

___
Freetype-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/freetype-devel