Re: [ft-devel] Haarmony LCD rendering
On Wed, Aug 9, 2017 at 3:50 PM Alexei Podtelezhnikov wrote: > On Wed, Aug 9, 2017 at 6:15 AM, Markus Trippelsdorf < > mar...@trippelsdorf.de> wrote: > > Yes, the fix is already in Chromium, but Firefox needs it, too: > > > https://skia.googlesource.com/skia/+/d1f2d15b36f6a6a9d199581b998a7ca924a1f1a8%5E%21/ > > I strongly suspect that this fix is inadequate. Skia continues to > pre-allocate the buffer too early. The fix just fits the FreeType > buffer in the pre-allocated space. It happens to work for ClearType > because we shrunk our buffer in this case. The default LCD image, on > the other hand, is now a bit larger, so it won't fit in the > pre-allocated space. I do not understand why Skia pre-allocates the > buffer instead of just taking what FreeType returns. That would be a > better fix. > It is indeed inadequate. I just tested a patched Firefox Nightly against FreeType master, with old and new LCD rendering. Old looks fine but Harmony still has some chopped glyphs. ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
On Wed, Aug 9, 2017 at 6:15 AM, Markus Trippelsdorf wrote: > On 2017.08.09 at 12:10 +0200, Werner LEMBERG wrote: >> >> > Unfortunately, it seems Firefox now cuts off many glyphs on the >> > right side. A lowercase i or l can become almost invisible. >> >> IIRC, this is a bug in Firefox; it relies on a certain glyph buffer >> layout that is not covered by the API but (incorrectly) derived from >> FreeType's internal representation. > > Yes, the fix is already in Chromium, but Firefox needs it, too: > https://skia.googlesource.com/skia/+/d1f2d15b36f6a6a9d199581b998a7ca924a1f1a8%5E%21/ I strongly suspect that this fix is inadequate. Skia continues to pre-allocate the buffer too early. The fix just fits the FreeType buffer in the pre-allocated space. It happens to work for ClearType because we shrunk our buffer in this case. The default LCD image, on the other hand, is now a bit larger, so it won't fit in the pre-allocated space. I do not understand why Skia pre-allocates the buffer instead of just taking what FreeType returns. That would be a better fix. ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
> Unfortunately, it seems Firefox now cuts off many glyphs on the > right side. A lowercase i or l can become almost invisible. IIRC, this is a bug in Firefox; it relies on a certain glyph buffer layout that is not covered by the API but (incorrectly) derived from FreeType's internal representation. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
On 2017.08.09 at 12:10 +0200, Werner LEMBERG wrote: > > > Unfortunately, it seems Firefox now cuts off many glyphs on the > > right side. A lowercase i or l can become almost invisible. > > IIRC, this is a bug in Firefox; it relies on a certain glyph buffer > layout that is not covered by the API but (incorrectly) derived from > FreeType's internal representation. Yes, the fix is already in Chromium, but Firefox needs it, too: https://skia.googlesource.com/skia/+/d1f2d15b36f6a6a9d199581b998a7ca924a1f1a8%5E%21/ -- Markus ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
On 2017.08.09 at 09:26 +, Jan Alexander Steffens wrote: > On Wed, Aug 9, 2017 at 5:11 AM Alexei Podtelezhnikov > wrote: > > > What do you think? > > > Great! As it's in master now I've given it a try. Unfortunately, it seems > Firefox now cuts off many glyphs on the right side. A lowercase i or l can > become almost invisible. > > On Wed, Aug 9, 2017 at 8:15 AM Markus Trippelsdorf > wrote: > > > What about vrgb rendering? > > > > Looking at the code, it seems that vertical orientation is covered. Well, it looks like this: https://ibb.co/jNKw6a rdb rendering, on the other hand, works fine. -- Markus ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
On Wed, Aug 9, 2017 at 5:11 AM Alexei Podtelezhnikov wrote: > What do you think? Great! As it's in master now I've given it a try. Unfortunately, it seems Firefox now cuts off many glyphs on the right side. A lowercase i or l can become almost invisible. On Wed, Aug 9, 2017 at 8:15 AM Markus Trippelsdorf wrote: > What about vrgb rendering? > Looking at the code, it seems that vertical orientation is covered. ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] Haarmony LCD rendering
On 2017.08.08 at 23:10 -0400, Alexei Podtelezhnikov wrote: > > What do you think? What about vrgb rendering? -- Markus ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
