Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-29 Thread Werner LEMBERG
I've placed the patch at https://bugs.freedesktop.org/show_bug.cgi?id=603 I think it's not really appropriate to copy the patch to the freetype.org list of patches for rogue clients, since there are a couple of other issues in the modular build (unrelated to freetype internals) which X.org

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-29 Thread Werner LEMBERG
Well, it would be nice if the above is mentioned on that page. Can you provide a small patch for rogue-patches.html which tells the user what he or she shall do w.r.t. xprint? How does the attached look? Thanks a lot! I've applied it. Werner

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-29 Thread Drew Parsons
On Sun, 2006-01-29 at 01:21 +0100, Werner LEMBERG wrote: I've placed the patch at https://bugs.freedesktop.org/show_bug.cgi?id=603 I think it's not really appropriate to copy the patch to the freetype.org list of patches for rogue clients, since there are a couple of other issues in

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-26 Thread Werner LEMBERG
src/type1/t1objs.c (403): root-bbox.xMin = type1-font_bbox.xMin 16; root-bbox.yMin = type1-font_bbox.yMin 16; root-bbox.xMax = ( type1-font_bbox.xMax + 0xU ) 16; root-bbox.yMax = ( type1-font_bbox.yMax + 0xU ) 16; It looks to

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-26 Thread Chia-I Wu
On Fri, Jan 27, 2006 at 06:14:48AM +0100, Werner LEMBERG wrote: src/type1/t1objs.c (403): root-bbox.xMin = type1-font_bbox.xMin 16; root-bbox.yMin = type1-font_bbox.yMin 16; root-bbox.xMax = ( type1-font_bbox.xMax + 0xU ) 16;

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-25 Thread Chia-I Wu
Hi, This is not related to the discussion but related to freetype internal. On Mon, Jan 23, 2006 at 11:20:41AM +0100, david turner wrote: src/type1/t1objs.c (403): root-bbox.xMin = type1-font_bbox.xMin 16; root-bbox.yMin = type1-font_bbox.yMin 16;

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-24 Thread david turner
Hi Drew, I think your option A would probably be safe. But if you do think providing the API would be generally useful, then let me know when it's implemented, I could upgrade the Xprint to use it in the future. I don't think it is useful for ordinary users of the library. The programs

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-24 Thread Drew Parsons
On Tue, 2006-01-24 at 11:50 +0100, david turner wrote: Hi Drew, I suspect I can remove the (int) cast here too, since the face-bbox values are already integers, would that be correct? the values are longs. Apart from that, you're correct ! Good-o. But wait, there is more: the

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-24 Thread Drew Parsons
On Tue, 2006-01-24 at 12:46 +0100, david turner wrote: So, the correct, non-buggy code would be: else { fprintf(out, /FontBBox [%ld %ld %ld %ld] def\n, ti-ttface-bbox-xMin, ^^ Is

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-24 Thread David Turner
Drew Parsons a écrit : OK. In that case you mean the 65536 needs to removed from the other 3 coords. That is I want: else { fprintf(out, /FontBBox [%ld %ld %ld %ld] def\n, ti-ttface-bbox-xMin, ti-ttface-bbox-yMin, ti-ttface-bbox-xMax,

Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

2006-01-23 Thread david turner
Hello Drew, thanks a *lot* for this e-mail. Here's what I've understood of the situation: - first of all, the fact that the code includes t42types.h means that the original developer assumed that Xprint was using the version of FreeType embedded within the X server, since this header has