[ft] FT_Done_Face Should Not Return An Error

It is common for object-disposal routines to never return error statuses. The archetypal example is free(3) . If this is passed a valid pointer, it disposes of the object; if it is passed NULL, it quietly returns without doing anything. If it is passed an invalid

Re: [ft] FT_Done_Face Should Not Return An Error

On 5/5/2018 11:54 AM, Lawrence D'Oliveiro wrote: It is common for object-disposal routines to never return error statuses. The archetypal example is free(3) . If this is passed a valid pointer, it disposes of the object; if it is passed NULL, it quietly returns

Re: [ft] FT_Done_Face Should Not Return An Error

>> It is common for object-disposal routines to never return error >> statuses. The archetypal example is free(3) >> . If this is passed a valid >> pointer, it disposes of the object; if it is passed NULL, it >> quietly returns without doing anything. If it is

Re: [ft] FT_Done_Face Should Not Return An Error

On Sat, May 5, 2018 at 11:10 AM, Werner LEMBERG wrote: > > >> It is common for object-disposal routines to never return error > >> statuses. The archetypal example is free(3) > >> . If this is passed a valid > >> pointer, it disposes of the

Re: [ft] FT_Done_Face Should Not Return An Error

On 5/5/2018 11:32 PM, Lawrence D'Oliveiro wrote: On Sat, 5 May 2018 19:49:30 +0200, Gregor Mückl wrote: Please don't create another library that blindly terminates its host program on a whim. s/whim/internal consistency failure/ Which is a whim as far as the caller is concerned, isn't it?

Re: [ft] FT_Done_Face Should Not Return An Error

On Sun, 6 May 2018 00:11:12 +0200, Gregor Mückl wrote: > Just don't assume that you know better than the creator of the host > program when it is okay to bail and how to do so. As the provider of the lower-level abstraction, you guarantee certain invariants. In this case, that every FT_Face has

Re: [ft] FT_Done_Face Should Not Return An Error

On Sat, 05 May 2018 20:10:43 +0200 (CEST), Werner LEMBERG wrote: > I agree with Gregor: A library should not call `exit' by itself. What else is it supposed to do? Lots of code is already ignoring the result from FT_Done_Face. Exhibit A: HarfBuzz

Re: [ft] FT_Done_Face Should Not Return An Error

On Sat, 5 May 2018 19:49:30 +0200, Gregor Mückl wrote: > Please don't create another library that blindly terminates its host > program on a whim. s/whim/internal consistency failure/ > Returning an error really is the right thing to do > here. Just make it clear that this is a bad error.

[ft-devel] [PATCH] Further fix to visibility flag testing with Solaris Studio compilers

AC_COMPILE_IFELSE only tries to compile a *.c to a *.o. The Solaris Studio 12.1 through 12.5 compilers see the -fvisibility=hidden flag, but ignore it with a warning of: cc: Warning: Option -fvisibility=hidden passed to ld, if ld is invoked, ignored otherwise AC_LINK_IFELSE does the compile