Re: [fricas-devel] error from normalize, bug in ataneval efstruc.spad

2016-06-01 Thread Waldek Hebisch
oldk1331 wrote: > > First, thanks for your informative response, I learn a lot > from it and other messages you posted before. I want > to know if you can put "appropriate portion" of your mail > into comments of source code, to document the limitation > of current code, so people who stumble int

Re: [fricas-devel] bug fixes, improvements and documents for efstruc.spad

2016-06-01 Thread oldk1331
OK, I get it now. You can commit the parts you feel comfortable, and I will following the standard in the future. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from

Re: [fricas-devel] bug fixes, improvements and documents for efstruc.spad

2016-06-01 Thread Waldek Hebisch
oldk1331 wrote: > > along with some improvements: > > 1. I changed local type abbreviation to avoid conflict: > I changed "UP ==> SparseUnivariatePolynomial R" > into "SUPR ==> SparseUnivariatePolynomial R", > so that a spad expression "x::SUPR" can be copy & pasted > into interpreter, easier for

Re: [fricas-devel] $tryRecompileArguments causes compiling spad file failure

2016-06-01 Thread Waldek Hebisch
oldk1331 wrote: > > So, this is how I summarize it: > > 1. Short patch, ready to commit: post it in mail. > > 2. Long patch, ready to commit: post in attachment or post > with a link to the patch that can be directly downloaded. > > But if there a is a long patch (set) needs discussion and > r

Re: [fricas-devel] Re: bug fixes, improvements and documents for efstruc.spad

2016-06-01 Thread Waldek Hebisch
oldk1331 wrote: > > https://github.com/fricas/fricas/commit/9b62873dfb986f9b5f909254f31a0f4fa2b= > 05421.patch > > fix symFunc to match its document > fix TANEXP which depends on symFunc Looks reasonable. However, I do not know why original authors choose to mess with signs. AFAICS to_vec

Re: [fricas-devel] SmithNormalForm

2016-06-01 Thread Kurt Pagani
I find the trick Waldek describes quite amazing (never seen it before) and I dare saying: forget about translating sage code ;) Am 01.06.2016 um 10:33 schrieb Martin Baker: > Kurt and Waldek, > > Thank you very much for your help, I was stuck but now I have a way > forward. > > Martin B > > On

Re: [fricas-devel] Re: bug fixes, improvements and documents for efstruc.spad

2016-06-01 Thread Kurt Pagani
Am 01.06.2016 um 04:56 schrieb oldk1331: > Yes, you are right, I've fixed symFunc to match its description. > > The next problem is to fix TANEXP accordingly, which I'll do > later. But now is the problem of document it: > > Take tanPIa for example, tanPIa returns a FRAC SUPR, > which has this p

Re: [fricas-devel] SmithNormalForm

2016-06-01 Thread Martin Baker
Kurt and Waldek, Thank you very much for your help, I was stuck but now I have a way forward. Martin B On 31/05/16 23:24, Waldek Hebisch wrote: Kurt Pagani wrote: (11) -> completeSmith(A)$SMNF (11) +2 0 0 ++ 100 + +1 - 2 - 2+ |