Re: [fricas-devel] [PATCH] misc cleanup: use 'concat' instead of '"append"/'

2019-08-06 Thread Ralf Hemmecke
Hi Qian, I support such a change, in fact, I don't like something like "+" / list because it's not exactly clear what happens for the empty list. I'd rather always put the three-argument "reduce" in order to specify the value that is to be returned for the empty list. Note that

[fricas-devel] [PATCH] misc cleanup: use 'concat' instead of '"append"/'

2019-08-06 Thread oldk1331
I don't like the grammar that uses "func"/list1 to do reduce(func, list1) First, this is a strange grammar. Also I don't like to have special grammar to do things can be done by normal grammar. This patch replaces '"append"/' with normal function call 'concat : List % -> %', it's