Re: [fricas-devel] [PATCH] rootPower(): handle embedded roots

2017-02-17 Thread Waldek Hebisch
> > > AFAICS the correct way is to > > first perform substitutions only inside kernels and then > > apply resulting substitution list to x (like in the rootSimp case) > > Should this be the comment of this function? No. > Also, rootPower will not change the height of a kernel, right?

Re: [fricas-devel] [PATCH] rootPower(): handle embedded roots

2017-02-17 Thread oldk1331
> AFAICS the correct way is to > first perform substitutions only inside kernels and then > apply resulting substitution list to x (like in the rootSimp case) Should this be the comment of this function? Also, rootPower will not change the height of a kernel, right? diff --git

Re: [fricas-devel] [PATCH] rootPower(): handle embedded roots

2017-02-17 Thread Waldek Hebisch
oldk1331 wrote: > > (1) -> rootPower atan(2*(x^(1/6))^3) > > 6+-+3 >(1) atan(2\|x ) > > After patch: > > (2) -> rootPower atan(2*(x^(1/6))^3) > >+-+ >(2) atan(2\|x ) > > Similar to previous rootSimp, rootPower doesn't handle > nested roots correctly:

[fricas-devel] [PATCH] rootPower(): handle embedded roots

2017-02-16 Thread oldk1331
(1) -> rootPower atan(2*(x^(1/6))^3) 6+-+3 (1) atan(2\|x ) After patch: (2) -> rootPower atan(2*(x^(1/6))^3) +-+ (2) atan(2\|x ) Similar to previous rootSimp, rootPower doesn't handle nested roots correctly: it overlooked the case when root appears at