[Frugalware-git] fw32: fw32.c: simplify error handling in mkdir_parents

2011-11-02 Thread James Buren
Git-Url: http://git.frugalware.org/gitweb/gitweb.cgi?p=fw32.git;a=commitdiff;h=fd0925f22b65095426dabb9b33162c76c10d86ad commit fd0925f22b65095426dabb9b33162c76c10d86ad Author: James Buren r...@frugalware.org Date: Wed Nov 2 04:08:45 2011 -0500 fw32.c: simplify error handling in mkdir_parents

Re: [Frugalware-git] fw32: fw32.c: simplify error handling in mkdir_parents

2011-11-02 Thread Michel Hermier
This code is totally broken. Setting errno is a no go in glibc, it's a read only variable (on some glibc it is a macro to a function) As a consequence, your mkdir checking is broken, you should really check mkdir returned values and then check errno on failure value. Also you could make a small