Quoting extended variables

2006-06-03 Thread Mikhael Goikhman
I think the ultimate solution is explained in file doc/todo-vars.
Among other things, it says that we only have variables in format $[],
all one letter variables are deprecated, and that a user may request
not to quote a value or choose from several quoting styles.

However, we should decide about the default behaviour of variables
(when no explicit filters are specified).

All variables with integer value like $[w.x] or fixed string value like
$[version.num] should not be quoted by default.

All window name related variables should be qingle-quoted by default.
There is no question here, because names are really arbitrary.

However, it is not clear about other less-arbitrary strings. I.e. should
$. be quoted? Currently it is quoted, but there is almost no chance
someone has quote characters in fvwm directories. On the other hand,
spaces are a bit more likely, so quoting here has pluses (less to type)
and minuses (may be surprised).

Should $[w.iconfile] and $[w.miniiconfile] be quoted by default?

And finally, should $[ENV_VAR] like $[PATH] be quoted by default?

I see pros and cons to do this. Most of variable values (even $PATH) has
an expected value, so a user may guess about a proper quoting on his own.
On the other hand, the consistent solution would be to always quote any
string var.

Regards,
Mikhael.



CVS migo: * fix $[w.name], $[w.iconname], $[w.class] and $[w.resource]

2006-06-03 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo06/06/03 19:19:25

Modified files:
.  : ChangeLog 
fvwm   : expand.c fvwm.1.in 

Log message:
* fix $[w.name], $[w.iconname], $[w.class] and $[w.resource]
_ to behave like deprecated $n, $c and $r, i.e. quote them
_ and describe this in the man page




CVS migo: * convert expand_vars_extended function to have a single return point

2006-06-03 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo06/06/03 18:19:16

Modified files:
.  : ChangeLog 
fvwm   : expand.c 

Log message:
* convert expand_vars_extended function to have a single return point
_ this is good to implement doc/todo-vars filters in the futire




Re: Title font color broken

2006-06-03 Thread Dan Espen
"Thomas Adam" <[EMAIL PROTECTED]> writes:
> On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote:
> > 
> > It's been a while since I've updated to CVS Maybe a month or 2   .
> >
> > After the last update, the text in my window titles is black. These
> > commands have no effect:
> >
> > Style * ForeColor HilightFore
> 
> Last I heard those commands were being deprecated in favour of using
> colorsets.

Good thing someone is still using them so we don't break things that
are only deprecated.

Actually, I don't see anything in the man page about colorsets being
required.

-- 
Dan Espen   E-mail: [EMAIL PROTECTED]



CVS migo: * minor tweaks, like re-spacing and removing old "#if 0" code

2006-06-03 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: migo06/06/03 14:37:21

Modified files:
.  : ChangeLog 
fvwm   : expand.c 

Log message:
* minor tweaks, like re-spacing and removing old "#if 0" code




Re: Title font color broken

2006-06-03 Thread Thomas Adam
On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote:
> 
> It's been a while since I've updated to CVS Maybe a month or 2   .
>
> After the last update, the text in my window titles is black. These
> commands have no effect:
>
> Style * ForeColor HilightFore

Last I heard those commands were being deprecated in favour of using
colorsets.

-- Thomas Adam

-- 
"If I were a witch's hat, sitting on her head like a paraffin stove, I'd
fly away and be a bat." -- Incredible String Band.



Title font color broken

2006-06-03 Thread Dan Espen

It's been a while since I've updated to CVS.
Maybe a month or 2.

After the last update, the text in my window titles is black.
These commands have no effect:

Style * ForeColor white
Style * HilightFore white

So far, I don't see the change that broke this.

-- 
Dan Espen   E-mail: [EMAIL PROTECTED]