CVS renato: removed the Imlib.h header from gdk_imlib test programs
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/09/04 15:47:31 Modified files: . : ChangeLog acinclude.m4 Log message: removed the Imlib.h header from gdk_imlib test programs
Re: [patch]: detecting gdk-imlib11 by configure
On 9/4/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > On 9/4/06, Harald Dunkel <[EMAIL PROTECTED]> wrote: > > seventh guardian wrote: > > > > > > I see your point, and I agree that things may not be working > > > correctly. But what you did is a hack. You just changed the test > > > program to detect imlib when it is not there. > > > > > > Even if it works that way, it should be done properly. Probably a > > > cleanup would be good.. There's a bunch of dup/unused code in that > > > file.. > > > > > > > Since no part of fvwm (except for acinclude.m4) makes use of > > imlib-dev, would it be OK to remove the tests for imlib-dev > > in acinclude.m4 (afap), and keep just the tests for gdk-imlib-dev? > > Just to reduce the number of lines of code to cleanup? > > Its not that simple, acinclude is a bunch of functions "included" by > configure.ac. Both files would need to be revised. But the idea is > correct: to remove the tests for imlib and cleanup the ones for > gdk-imlib. > > Any second opinions about this? If we really do not use "implib" I'm all for removing the test. It's causing endless troubles for me. Ok, done. It's strange, but it seems that the imlib test macro was realy never used! So it's strange how it affected the compilation under Debian.. Harald does it work now? Cheers Renato Ciao Dominik ^_^ ^_^ -- "Feel free" – 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail
CVS renato: Removed the unused test for plain imlib.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/09/04 15:39:35 Modified files: . : ChangeLog acinclude.m4 Log message: Removed the unused test for plain imlib. The test for gdk-imlib is left as-was.
Re: [patch]: detecting gdk-imlib11 by configure
On 9/4/06, Harald Dunkel <[EMAIL PROTECTED]> wrote: seventh guardian wrote: > > I see your point, and I agree that things may not be working > correctly. But what you did is a hack. You just changed the test > program to detect imlib when it is not there. > > Even if it works that way, it should be done properly. Probably a > cleanup would be good.. There's a bunch of dup/unused code in that > file.. > Since no part of fvwm (except for acinclude.m4) makes use of imlib-dev, would it be OK to remove the tests for imlib-dev in acinclude.m4 (afap), and keep just the tests for gdk-imlib-dev? Just to reduce the number of lines of code to cleanup? Its not that simple, acinclude is a bunch of functions "included" by configure.ac. Both files would need to be revised. But the idea is correct: to remove the tests for imlib and cleanup the ones for gdk-imlib. Any second opinions about this? Cheers Renato Regards Harri
