Re: Request to increase 1024 char/line limit in read.c

[Stefan Blachmann]

Ooops, didn't think of that!

Then the only correct solution is to drop my request and leave things
as they are.
I'll then just store the parameters otherwhere (file).

Thank you guys for explaining!
Stefan

On 3/5/18, Dominik Vogt  wrote:
> On Mon, Mar 05, 2018 at 11:57:27AM +, Thomas Adam wrote:
>> Hi,
>>
>> On Mon, Mar 05, 2018 at 04:38:08AM +0100, Stefan Blachmann wrote:
>> > Hi fvwm-workers,
>> >
>> > the 1024 char limit in the read line buffer in fvwm/read.c has become
>> > too small.
>> > This caused a breakage in my MissingSubmenuFunction menu generator
>> > after after addition of programs + update; the Popup did not display.
>> >
>> > Could the buffer be extended to, say, 4096 chars?
>>
>> We'd be chasing stack limits if we do this.
>>
>> I'd much rather see that fgets() loop replaced with fparseln() instead,
>> which
>> would also solve this problem indefinitely.
>
> The reson for commnd line limitation is mostly the size limit of
> pipes (pipereas command and module communication).  In the past we
> used the largest value that every system guaranteed to support
> (256) and then increased that to 1024 at some time.
>
> Ciao
>
> Dominik ^_^  ^_^
>
> --
>
> Dominik Vogt
>

Re: Request to increase 1024 char/line limit in read.c

[Dominik Vogt]

On Mon, Mar 05, 2018 at 11:57:27AM +, Thomas Adam wrote:
> Hi,
> 
> On Mon, Mar 05, 2018 at 04:38:08AM +0100, Stefan Blachmann wrote:
> > Hi fvwm-workers,
> > 
> > the 1024 char limit in the read line buffer in fvwm/read.c has become too 
> > small.
> > This caused a breakage in my MissingSubmenuFunction menu generator
> > after after addition of programs + update; the Popup did not display.
> > 
> > Could the buffer be extended to, say, 4096 chars?
> 
> We'd be chasing stack limits if we do this.
> 
> I'd much rather see that fgets() loop replaced with fparseln() instead, which
> would also solve this problem indefinitely.

The reson for commnd line limitation is mostly the size limit of
pipes (pipereas command and module communication).  In the past we
used the largest value that every system guaranteed to support
(256) and then increased that to 1024 at some time.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

Re: Request to increase 1024 char/line limit in read.c

[Thomas Adam]

Hi,

On Mon, Mar 05, 2018 at 04:38:08AM +0100, Stefan Blachmann wrote:
> Hi fvwm-workers,
> 
> the 1024 char limit in the read line buffer in fvwm/read.c has become too 
> small.
> This caused a breakage in my MissingSubmenuFunction menu generator
> after after addition of programs + update; the Popup did not display.
> 
> Could the buffer be extended to, say, 4096 chars?

We'd be chasing stack limits if we do this.

I'd much rather see that fgets() loop replaced with fparseln() instead, which
would also solve this problem indefinitely.


-- Thomas Adam