Re: Crashes with monitor_resolve_name

2021-11-27 Thread Thomas Adam
On Sat, Nov 27, 2021 at 07:02:29PM +0100, Dominik Vogt wrote: > Are there other places with unusual monitor name parsing? Maybe in GotoDeskAndPage, but I don't think there's other places. -- Thomas

[PATCH] Re: Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 07:02:29PM +0100, Dominik Vogt wrote: > There are some NULL pointer crashes and bugs telated to > moitor_resove_ame(): Attempt to fix these, please proof read the patch. * Parsing fixes. * monitor_resolve_name() does not crash if scr == NULL but returns NULL. *

FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
From commit 601c5c294a6a48fd402fbfca02b62142796167eb >* Improved use of sizehints to set both minimum window size, and to > preserve aspect ratio when resizing the pager. The aspect ratio is > set to the initial size of the window unless the user sets window > size with the

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Jaimos Skriletz
On Sat, Nov 27, 2021 at 2:44 PM Jaimos Skriletz wrote: > > This can currently be disabled by proving an initial Geometry (though > it needs to be bigger than some minimum size I recall like 100x100) > then FvwmButtons will resize to fit without preserving aspect ratio. > I think I made it seem

Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
There are some NULL pointer crashes and bugs telated to moitor_resove_ame(): 1. The fuction assumes that it's always called with a non-null "scr" pointer: monitor_resolve_name(const char *scr) { ... if (strcmp(scr, "g") == 0) { This is not the case.

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Jaimos Skriletz
On Sat, Nov 27, 2021 at 1:59 PM Dominik Vogt wrote: > > From commit 601c5c294a6a48fd402fbfca02b62142796167eb > > >* Improved use of sizehints to set both minimum window size, and to > > preserve aspect ratio when resizing the pager. The aspect ratio is > > set to the initial size

Re: [PATCH] Re: Crashes with monitor_resolve_name

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 08:30:52PM +0100, Dominik Vogt wrote: > On Sat, Nov 27, 2021 at 07:02:29PM +0100, Dominik Vogt wrote: > > There are some NULL pointer crashes and bugs telated to > > moitor_resove_ame(): > > Attempt to fix these, please proof read the patch. > > * Parsing fixes. > *

Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-11-27 Thread Dominik Vogt
On Sat, Nov 27, 2021 at 02:44:07PM -0700, Jaimos Skriletz wrote: > On Sat, Nov 27, 2021 at 1:59 PM Dominik Vogt wrote: > > > > From commit 601c5c294a6a48fd402fbfca02b62142796167eb > > > > >* Improved use of sizehints to set both minimum window size, and to > > > preserve aspect ratio