Re: [PATCH] (2) fvwm3styles.1.
On Tue, Nov 16, 2021 at 08:28:12AM +, Thomas Adam wrote: > On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > > Two more patches for the man page branch, this time taking care of > > the style commands. > > > > 0001: General cleanup. > > 0002: Split of fvwm3styles.1. > > > > Need to be applied in this order. > > > > Please take a good look at the result of the patch stack. I think > > this is all going in the right direction. If you agree and see no > > problems, I'll make a fresh stack of acleaned up patches that can > > go to the master branch. > > I agree -- it's looking really good. :) The final patches are in the other thread. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
Re: [PATCH] (2) fvwm3styles.1.
On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > Two more patches for the man page branch, this time taking care of > the style commands. > > 0001: General cleanup. > 0002: Split of fvwm3styles.1. > > Need to be applied in this order. > > Please take a good look at the result of the patch stack. I think > this is all going in the right direction. If you agree and see no > problems, I'll make a fresh stack of acleaned up patches that can > go to the master branch. I agree -- it's looking really good. > There are various formatting problems left, but can be fixed later. Yes. > -- > > Off-topic: Can we remove the "globalopts" command description? Yes. I can see a small section that's still present. Kindly, Thomas
Re: [PATCH] (2) fvwm3styles.1.
On Tue, Nov 16, 2021 at 01:28:45AM +0100, Dominik Vogt wrote: > On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > > Off-topic: Can we remove the "globalopts" command description? > > And while we're at it, remove its implementation as well? > > At the moment, GlobalOpts: > > (1) Emits a deprecation warning ans prints the command that has to > be used instead. > (2) Executes that command automatically. > > We could remove just (2), leaving the warning in place, or just > eliminate the command completely. I say remove it completely -- both its implemention and in the documentation. I haven't seen a single config where GlobalOpts has ever been used, so I really do think we can be quite brutal here. It's about time. Thomas
Re: [PATCH] (2) fvwm3styles.1.
On Tue, Nov 16, 2021 at 01:18:24AM +0100, Dominik Vogt wrote: > Off-topic: Can we remove the "globalopts" command description? And while we're at it, remove its implementation as well? At the moment, GlobalOpts: (1) Emits a deprecation warning ans prints the command that has to be used instead. (2) Executes that command automatically. We could remove just (2), leaving the warning in place, or just eliminate the command completely. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
