Re: parser branch

2021-11-17 Thread Dominik Vogt
On Wed, Nov 17, 2021 at 06:20:05PM +, Thomas Adam wrote:
> On Wed, Nov 17, 2021 at 01:47:05PM +, Thomas Adam wrote:
> > On Wed, Nov 17, 2021 at 02:38:19PM +0100, Dominik Vogt wrote:
> > > I'd like to finish the parser work started in 2014.  Is the old
> > > branch still available somewhere?
> >
> > Remind me what work that was...
>
> I remember now.  It came in two parts.  The first part, you and I worked on
> documenting the commands in BNF notation (back in 2016).  That work is what
> got carried across to fvwm.
>
> Then you created some experimental code to start to clean things up.
>
> That work was done in the mvwm repository [1], and the two branches you'll
> want to look at are:

Thanks, found them and rebased the patches to master.  Couple of
hours to fix conflicts.  If you don't read from me for a while,
that will be because fvwm crashes with the changed parser.  ;-)

> I can't really remember where we got to with that work either -- I'm hoping
> this trip down memory lane might jog your memory more than it has mine.  ;)

The whole point in the completed part of the work was to make the
command line parser pluggable.  As far as I remember, that part
was done, but needed more testing by users.  Now that the rebase
potentially contains some mistakes and may miss some things that
have changed in between, it's even more important.

There is a slight incompatibility of the new code with some thiung
about quoting plus variable expansion.  I had started a thread on
the mailing list and asked if that would annoy anybody and the
people who replied said no.  Anyway (a) I cannot remember what it
was exactly (we can dig it up from the mail archive) and (b) there
won't be any progress if we make a new parser compatible with the
crappy bugs of the old one.

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt



Re: parser branch

2021-11-17 Thread Thomas Adam
On Wed, Nov 17, 2021 at 01:47:05PM +, Thomas Adam wrote:
> On Wed, Nov 17, 2021 at 02:38:19PM +0100, Dominik Vogt wrote:
> > I'd like to finish the parser work started in 2014.  Is the old
> > branch still available somewhere?
> 
> Remind me what work that was...

I remember now.  It came in two parts.  The first part, you and I worked on
documenting the commands in BNF notation (back in 2016).  That work is what
got carried across to fvwm.

Then you created some experimental code to start to clean things up.

That work was done in the mvwm repository [1], and the two branches you'll
want to look at are:

* dv/new-parser

  https://github.com/ThomasAdam/mvwm/commits/dv/new-parser

* dv/new-parser-2

  https://github.com/ThomasAdam/mvwm/commits/dv/new-parser-2

You could add mvwm as a git-remote in the fvwm3 repository and try and
cherry-pick/rebase the relevant commits.   But I suspect neither branches will
have any common ancestry with the master branch, so that might not work as
well.  But you could solve that through using grafts if you really wanted to.

I can't really remember where we got to with that work either -- I'm hoping
this trip down memory lane might jog your memory more than it has mine.  ;)

HTH,

Thomas

[1]:  https://github.com/ThomasAdam/mvwm



Re: parser branch

2021-11-17 Thread Thomas Adam
On Wed, Nov 17, 2021 at 02:38:19PM +0100, Dominik Vogt wrote:
> I'd like to finish the parser work started in 2014.  Is the old
> branch still available somewhere?

Remind me what work that was...

Kindly,
Thomas



parser branch

2021-11-17 Thread Dominik Vogt
I'd like to finish the parser work started in 2014.  Is the old
branch still available somewhere?

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt