Re: [galaxy-dev] Galaxy BLAST XML to tabular fix

2011-05-25 Thread Peter Cock
On Wed, May 18, 2011 at 6:40 PM, Peter Cock p.j.a.c...@googlemail.com wrote:
 Hi Kanwei,

 Could you merge this branch or transplant this fix please?

 https://bitbucket.org/peterjc/galaxy-central/changeset/3c0b903c86a9

 https://bitbucket.org/peterjc/galaxy-central/src/blast_2011_05_18

 New branch, blast_2011_05_18

 There is no change to the logic, just to the assert statement where
 the sanity test didn't consider doubly masked sequences.

 Should I also update the XML wrapper's version number as well?

 Thanks,

 Peter

Hi Kanwei,

Did this email reach you? Let me know if you want a new unit
test to go with it and/or to bump the tool's version number.

Regards,

Peter
___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/


Re: [galaxy-dev] Galaxy BLAST XML to tabular fix

2011-05-25 Thread Kanwei Li
Sorry, it slipped by. Committed!

On Wed, May 25, 2011 at 12:48 PM, Peter Cock p.j.a.c...@googlemail.comwrote:

 On Wed, May 18, 2011 at 6:40 PM, Peter Cock p.j.a.c...@googlemail.com
 wrote:
  Hi Kanwei,
 
  Could you merge this branch or transplant this fix please?
 
  https://bitbucket.org/peterjc/galaxy-central/changeset/3c0b903c86a9
 
  https://bitbucket.org/peterjc/galaxy-central/src/blast_2011_05_18
 
  New branch, blast_2011_05_18
 
  There is no change to the logic, just to the assert statement where
  the sanity test didn't consider doubly masked sequences.
 
  Should I also update the XML wrapper's version number as well?
 
  Thanks,
 
  Peter

 Hi Kanwei,

 Did this email reach you? Let me know if you want a new unit
 test to go with it and/or to bump the tool's version number.

 Regards,

 Peter

___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/

Re: [galaxy-dev] Galaxy BLAST XML to tabular fix

2011-05-25 Thread Peter Cock
On Wed, May 25, 2011 at 1:10 PM, Kanwei Li kan...@gmail.com wrote:
 Sorry, it slipped by. Committed!


No problem - thank you,

Peter
___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/