Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Peter Cock
On Thu, Feb 13, 2014 at 7:51 AM, Björn Grüning bjoern.gruen...@gmail.com wrote: Am Mittwoch, den 12.02.2014, 10:46 + schrieb Peter Cock: ... However, at only 5kb the FASTA file is small and fine to bundle - but the BAM (49kb), log (123kb) and MAF (764kb) quickly add up so I would prefer

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Daniel Blankenberg
Hi all, I just wanted to point out that there are several different ways to compare the history output item to a test file beyond the default “diff”, including contains, re_match, sim_size, etc, this is set by the “compare” attribute in the xml tag for the test output. If you really don’t

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Peter Cock
On Thu, Feb 13, 2014 at 1:58 PM, Daniel Blankenberg d...@bx.psu.edu wrote: Hi all, I just wanted to point out that there are several different ways to compare the history output item to a test file beyond the default diff, including contains, re_match, sim_size, etc, this is set by the

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Greg Von Kuster
Hello Peter, I'm also sure we could enhance hte twill code to use the dictionary approach used in the API based testing. However, pervasive use of Javascript is being introduced into the Galaxy code base at a fast pace and twill does not work with Javascript. So clearly the use of twill for

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Björn Grüning
Hi Dan, Hi all, I just wanted to point out that there are several different ways to compare the history output item to a test file beyond the default “diff”, including contains, re_match, sim_size, etc, this is set by the “compare” attribute in the xml tag for the test output. If you

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-13 Thread Greg Von Kuster
Hi Björn, I think twill is going to be around for a while yet, but it is quickly becoming more critical to eliminate it. I haven't yet looked at Johns tests using the API, but my understanding is that they are focused on tools. We're using twill a lot in other areas besides tools, so it will

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-12 Thread Peter Cock
On Tue, Feb 11, 2014 at 5:09 PM, Peter Cock p.j.a.c...@googlemail.com wrote: On Tue, Feb 11, 2014 at 4:42 PM, Peter Cock p.j.a.c...@googlemail.com wrote: On Tue, Feb 11, 2014 at 3:41 PM, Dave Bouvier d...@bx.psu.edu wrote: Peter, Thanks for pointing this out, I've applied your changes in

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-12 Thread Björn Grüning
Am Mittwoch, den 12.02.2014, 10:46 + schrieb Peter Cock: On Tue, Feb 11, 2014 at 5:09 PM, Peter Cock p.j.a.c...@googlemail.com wrote: On Tue, Feb 11, 2014 at 4:42 PM, Peter Cock p.j.a.c...@googlemail.com wrote: On Tue, Feb 11, 2014 at 3:41 PM, Dave Bouvier d...@bx.psu.edu wrote:

[galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-11 Thread Peter Cock
On Tue, Feb 11, 2014 at 3:41 PM, Dave Bouvier d...@bx.psu.edu wrote: Peter, Thanks for pointing this out, I've applied your changes in 12478:15fc8675064e on the default branch. --Dave B. Thanks Dave, RE: http://lists.bx.psu.edu/pipermail/galaxy-dev/2014-February/018154.html

Re: [galaxy-dev] Twill compares wrong file; was: Twill comparisons ignore GALAXY_TEST_NO_CLEANUP

2014-02-11 Thread Peter Cock
On Tue, Feb 11, 2014 at 4:42 PM, Peter Cock p.j.a.c...@googlemail.com wrote: On Tue, Feb 11, 2014 at 3:41 PM, Dave Bouvier d...@bx.psu.edu wrote: Peter, Thanks for pointing this out, I've applied your changes in 12478:15fc8675064e on the default branch. --Dave B. Thanks Dave, RE: