[galaxy-dev] $GALAXY_SLOTS is set incorrectly when using LSF

2014-05-15 Thread Sytchev, Ilya
Hi,

I've noticed that $GALAXY_SLOTS that was always set to 1 when using LSF.
It turns out that LSF specifies the number of parallel slots using
$LSB_DJOB_NUMPROC env variable which isn't checked in
lib/galaxy/jobs/runners/util/job_script/CLUSTER_SLOTS_STATEMENT.sh.  A
diff that describes the fix is attached.

Ilya

diff -r 61a3094bd3ed 
lib/galaxy/jobs/runners/util/job_script/CLUSTER_SLOTS_STATEMENT.sh
--- a/lib/galaxy/jobs/runners/util/job_script/CLUSTER_SLOTS_STATEMENT.sh
Wed May 14 12:15:54 2014 -0400
+++ b/lib/galaxy/jobs/runners/util/job_script/CLUSTER_SLOTS_STATEMENT.sh
Thu May 15 16:12:04 2014 -0400
@@ -8,6 +8,8 @@
 GALAXY_SLOTS=$NSLOTS
 elif [ -f $PBS_NODEFILE ]; then
 GALAXY_SLOTS=`wc -l  $PBS_NODEFILE`
+elif [ -n $LSB_DJOB_NUMPROC ]; then
+GALAXY_SLOTS=$LSB_DJOB_NUMPROC
 else
 GALAXY_SLOTS=1
 unset GALAXY_SLOTS_CONFIGURED
___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/

Re: [galaxy-dev] $GALAXY_SLOTS is set incorrectly when using LSF

2014-05-15 Thread John Chilton
Awesome! Thanks for the patch - it has been committed as the following
changeset.

https://bitbucket.org/galaxy/galaxy-central/commits/fcd83883072c64b96ea0f12582fde3d05060b0f4

If anyone else is using something other then LSF, Torque, SLURM,
Condor, or SGE - please be aware of this potential problem and send a
patch for your platform :).

Thanks again,
-John

On Thu, May 15, 2014 at 3:40 PM, Sytchev, Ilya
isytc...@hsph.harvard.edu wrote:
 Hi,

 I've noticed that $GALAXY_SLOTS that was always set to 1 when using LSF.
 It turns out that LSF specifies the number of parallel slots using
 $LSB_DJOB_NUMPROC env variable which isn't checked in
 lib/galaxy/jobs/runners/util/job_script/CLUSTER_SLOTS_STATEMENT.sh.  A
 diff that describes the fix is attached.

 Ilya


 ___
 Please keep all replies on the list by using reply all
 in your mail client.  To manage your subscriptions to this
 and other Galaxy lists, please use the interface at:
   http://lists.bx.psu.edu/

 To search Galaxy mailing lists use the unified search at:
   http://galaxyproject.org/search/mailinglists/
___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/