Yep, you're absolutely right. Looking at it, the intent was for slug_set to be a flag that indicates if *any* slug was set, so we know to flush (only once, we don't want to do so inside the loop). I've fixed this in changeset 6258:6ec2d7f4a64d.
Thanks! -Dannon On Nov 10, 2011, at 2:43 PM, Andrew Warren wrote: > Potential bug? I haven't seen any effects of this, and I don't really know > whats going on with slugs, but I just wanted to mention it in case its an > issue. Starting on line 149 of lib/galaxy/web/controllers/workflow.py there > is a section of code for creating slugs for shared workflows. There is a loop > there for slug creation and the following check OUTSIDE the loop: > > if slug_set: > trans.sa_session.flush() > > Should that be in the loop? Otherwise its just flushing the session if the > last workflow gets a slug created. > > -Andrew Warren > ___________________________________________________________ > Please keep all replies on the list by using "reply all" > in your mail client. To manage your subscriptions to this > and other Galaxy lists, please use the interface at: > > http://lists.bx.psu.edu/ ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: http://lists.bx.psu.edu/
