Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
On Fri, Jun 10, 2016 at 12:07:45PM +0100, Brian Foley wrote: > On Fri, Jun 10, 2016 at 12:33:23PM +0200, 'Iustin Pop' via ganeti-devel wrote: > > On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > > > It looks like commit c429dd26 introduced the use of atomicModifyIORef', > > > which >

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Fri, Jun 10, 2016 at 12:33:23PM +0200, 'Iustin Pop' via ganeti-devel wrote: > On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > > It looks like commit c429dd26 introduced the use of atomicModifyIORef', > > which > > is only present in base 4.6 (GHC 7.6). Let's temporarily fix that

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > It looks like commit c429dd26 introduced the use of atomicModifyIORef', which > is only present in base 4.6 (GHC 7.6). Let's temporarily fix that by adding a > small compat layer (which undoes the optimisations of using strict on 7.4,

[PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
It looks like commit c429dd26 introduced the use of atomicModifyIORef', which is only present in base 4.6 (GHC 7.6). Let's temporarily fix that by adding a small compat layer (which undoes the optimisations of using strict on 7.4, but at least it works), until we decide to officially drop support