Re: [PATCH stable-2.16] Improve error reporting in _VerifyClientCertificates

2016-08-15 Thread 'Brian Foley' via ganeti-devel
On Mon, Aug 15, 2016 at 05:35:53AM -0700, 'Viktor Bachraty' via ganeti-devel wrote: >LGTM, thanks! [snip] >Nit: this was a bit confusing because in the 'else' case we have one >unconditional error and one conditional, so bad_mc_certs is >unconditionally true. I wonder if

Re: [PATCH stable-2.16] Improve error reporting in _VerifyClientCertificates

2016-08-15 Thread 'Viktor Bachraty' via ganeti-devel
LGTM, thanks! On Friday, August 12, 2016 at 4:49:46 PM UTC+1, Brian Foley wrote: > > Let the user know that the issues can be fixed using > gnt-cluster renew-crypto --new-node-certificates > > Signed-off-by: Brian Foley > --- > lib/cmdlib/cluster/verify.py | 92 >

[PATCH stable-2.16] Improve error reporting in _VerifyClientCertificates

2016-08-12 Thread 'Brian Foley' via ganeti-devel
Let the user know that the issues can be fixed using gnt-cluster renew-crypto --new-node-certificates Signed-off-by: Brian Foley --- lib/cmdlib/cluster/verify.py | 92 ++ test/py/cmdlib/cluster_unittest.py | 38 +--- 2