Re: [PATCH stable-2.15 03/17] Disable incorrect pylint assigning-non-slot warning

2016-12-06 Thread Iustin Pop
On 2016-12-06 17:30:00, Ganeti Development List wrote:
> This occurs pretty heavily in lib/objects.py, where pylint isn't
> correctly detecting the __slots__ assignment. This appears to be
> a known issue: https://github.com/PyCQA/pylint/issues/379

LGTM.


[PATCH stable-2.15 03/17] Disable incorrect pylint assigning-non-slot warning

2016-12-06 Thread 'Brian Foley' via ganeti-devel
This occurs pretty heavily in lib/objects.py, where pylint isn't
correctly detecting the __slots__ assignment. This appears to be
a known issue: https://github.com/PyCQA/pylint/issues/379

Signed-off-by: Brian Foley 
---
 lib/objects.py | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/objects.py b/lib/objects.py
index d6e64c9..23b349c 100644
--- a/lib/objects.py
+++ b/lib/objects.py
@@ -35,11 +35,14 @@ pass to and from external parties.
 
 """
 
-# pylint: disable=E0203,W0201,R0902
+# pylint: disable=E0203,E0237,W0201,R0902
 
 # E0203: Access to member %r before its definition, since we use
 # objects.py which doesn't explicitly initialise its members
 
+# E0237: Assigning to attribute not defined in class slots. pylint doesn't
+# appear to notice many of the slots defined in __slots__ for several objects.
+
 # W0201: Attribute '%s' defined outside __init__
 
 # R0902: Allow instances of these objects to have more than 20 attributes
-- 
2.8.0.rc3.226.g39d4020