On Mon, Dec 01, 2008 at 12:19:25PM -0700, Brad Nicholes wrote: > I don't understand what you are trying to do with this patch.
as explained in the commit message (which I apologize if it wasn't clear enough), it is correcting the definition of "modules" so it is correctly tagged as showing multiple times in the configuration as per : http://www.nongnu.org/confuse/manual/confuse_8h.html#a3 of course, I also adjusted all in tree code to use the correct syntax to retrieve all module definitions and that way avoid any problems. > Once libconfuse has finished reading and parsing the entire > configuration file along with all of the individual modules sections, > it automatically consolidates them into a single section. since the "modules" section contains only other subsections (in this case the section "module") which is defined as showing multiple times then all those subsections will be linked to the first section created, and which will be then accessible with a call to cfg_getsec("modules"). the problem with that, of course, is that we are then relying on an unintended sideffect of how the configuration structure is being created and that will break if another non section configuration is added later. I'd also argue that if all "modules" sections are to be collapsed anyway wouldn't be better to get rid of the "modules" configuration and just list all modules as part of the "root"? > There is no need to try to scan individual modules sections. if the configuration is defined to be shown multiple times, then a call to cfg_getsec will only get one of the instances. > This code was working correctly as it was. Please revert this patch. seems it was reverted already in r1931, so added some documentation of the latent problems in r1933 until the compatibility issues raised could be resolved. either implementation will work for the current setup but if you are to reconsider don't forget to revert r1933 as well. fixing any external module that would have problems looking at the module list (most likely useful for script handlers) shouldn't been that difficult IMHO. Carlo ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
