Re: [Ganglia-developers] $conf array

2011-02-25 Thread Alex Dean
I created http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=299. Added the conf-conversion script patches for eval_config.php and graph.php. I'll continue to convert other scripts as time allows. alex On Feb 24, 2011, at 10:05 PM, Alex Dean wrote: I wrote a script to read in a

Re: [Ganglia-developers] $conf array

2011-02-25 Thread Vladimir Vuksan
Alex, I have been using the $GLOBALS array for global configuration options. I would recommend using that instead of $conf http://sourceforge.net/apps/trac/ganglia/browser/branches/monitor-web-2.0/conf.php.in?rev=2489#L8 Thanks, Vladimir On Fri, 25 Feb 2011 09:51:17 -0600, Alex Dean

Re: [Ganglia-developers] $conf array

2011-02-25 Thread Alex Dean
Hi! I want the code to be clearer about which values are from configuration, which are from user input, and which are just local variables. Using $GLOBALS on it's own doesn't really address that concern. You could use something like $GLOBALS['conf']['ganglia_dir'], but it seems unnecessarily

Re: [Ganglia-developers] $conf array

2011-02-25 Thread Vladimir Vuksan
I see what you are saying. Sounds like a good plan. If you want to rename all $GLOBALS to $conf and user input to $user that would be cool :-). On Fri, 25 Feb 2011 14:04:20 -0600, Alex Dean a...@crackpot.org wrote: Hi! I want the code to be clearer about which values are from configuration,

Re: [Ganglia-developers] AUTHORS file

2011-02-25 Thread Bernard Li
Committed to trunk r2491: https://sourceforge.net/apps/trac/ganglia/changeset/2491 Thanks, Bernard On Wed, Feb 23, 2011 at 10:13 AM, Brad Nicholes bnicho...@novell.com wrote: On 2/22/2011 at 5:50 PM, in message AANLkTi=cjj5e461mbavnspkheqmksbxvndfcdvtzy...@mail.gmail.com, Bernard Li