Re: [Ganglia-developers] Dead code in web/meta_view.php

2010-09-08 Thread Bernard Li
Just a quick note saying that the "{Explanation}" tag has been removed as part of the Dwoo replacement commit: http://sourceforge.net/apps/trac/ganglia/changeset/2334 Cheers, Bernard On Thu, Aug 26, 2010 at 3:48 PM, Bernard Li wrote: > Found another one: > > http://sourceforge.net/apps/trac/ga

Re: [Ganglia-developers] Dead code in web/meta_view.php

2010-08-26 Thread Bernard Li
Found another one: http://sourceforge.net/apps/trac/ganglia/browser/trunk/monitor-core/web/templates/default/physical_view.tpl#L83 Last line has "{Explanation}" which is not defined anywhere else in the code. Cheers, Bernard On Wed, Aug 25, 2010 at 7:17 PM, Jesse Becker wrote: > Looks dead to

Re: [Ganglia-developers] Dead code in web/meta_view.php

2010-08-25 Thread Jesse Becker
Looks dead to me too. Nuke away. On Wed, Aug 25, 2010 at 20:27, Bernard Li wrote: > Hi guys: > > Have a look at line 147 and 148 of web/meta_view.php in trunk: > > http://sourceforge.net/apps/trac/ganglia/browser/trunk/monitor-core/web/meta_view.php#L147 > > there seems to be a syntax error with

[Ganglia-developers] Dead code in web/meta_view.php

2010-08-25 Thread Bernard Li
Hi guys: Have a look at line 147 and 148 of web/meta_view.php in trunk: http://sourceforge.net/apps/trac/ganglia/browser/trunk/monitor-core/web/meta_view.php#L147 there seems to be a syntax error with the $tpl->assign() call. That line essentially is no-op since there is no variable specified f