Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Carlo Marcelo Arenas Belon
On Tue, Feb 12, 2008 at 04:57:25PM -0800, Bernard Li wrote: Guys: I plan to check-in the following patch and release 3.0.7: can we use the same exact code already committed in trunk (including spaces and other details) so that there are no unnecessary divergences in the maintenance branch?

Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Carlo Marcelo Arenas Belon
On Wed, Feb 13, 2008 at 05:00:56AM -0600, Carlo Marcelo Arenas Belon wrote: On Tue, Feb 12, 2008 at 04:57:25PM -0800, Bernard Li wrote: Guys: I plan to check-in the following patch and release 3.0.7: can we use the same exact code already committed in trunk (including spaces and other

[Ganglia-developers] htmlentities to print the graph command when debugging under 3.0.6?

2008-02-13 Thread Carlo Marcelo Arenas Belon
Greetings, while looking at a diff between the 3.0.x branch and trunk for the web frontend noticed the following snippet (htmlentities is missing in 3.0.x) : @@ -331,7 +330,7 @@ header (Pragma: no-cache); // HTTP/1.0 if ($debug) { header (Content-type:

Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Jesse Becker
On Feb 13, 2008 6:00 AM, Carlo Marcelo Arenas Belon [EMAIL PROTECTED] wrote: On Tue, Feb 12, 2008 at 04:57:25PM -0800, Bernard Li wrote: Guys: I plan to check-in the following patch and release 3.0.7: can we use the same exact code already committed in trunk (including spaces and other

Re: [Ganglia-developers] htmlentities to print the graph command when debugging under 3.0.6?

2008-02-13 Thread alex
Quoting Carlo Marcelo Arenas Belon [EMAIL PROTECTED]: Greetings, while looking at a diff between the 3.0.x branch and trunk for the web frontend noticed the following snippet (htmlentities is missing in 3.0.x) : @@ -331,7 +330,7 @@ header (Pragma: no-cache); //

Re: [Ganglia-developers] ideas on sanitizing variables.

2008-02-13 Thread Jesse Becker
On Feb 13, 2008 11:46 AM, [EMAIL PROTECTED] wrote: Quoting Jesse Becker [EMAIL PROTECTED]: You said the only patching would be to include this script in get_context.php and graph.php. So, I take that to mean that get_context.php and graph.php would still access values in $_GET like they

Re: [Ganglia-developers] ideas on sanitizing variables.

2008-02-13 Thread alex
Quoting Jesse Becker [EMAIL PROTECTED]: Attached is a bunch of variable sanitation checking. It isn't done, but I wanted to throw it out for comments before I go too far down some hole and can't dig myself out. This is not a patch, since are only two include_once lines (in index.php and

Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Bernard Li
Hi guys: On 2/13/08, Carlo Marcelo Arenas Belon [EMAIL PROTECTED] wrote: agree and done as such for trunk so that the change needed by this fix can be identified clearly. r962 | carenas | 2008-02-13 03:28:21 -0800 (Wed, 13 Feb 2008) | 2 lines web: trailing spaces

Re: [Ganglia-developers] ideas on sanitizing variables.

2008-02-13 Thread alex
Quoting Jesse Becker [EMAIL PROTECTED]: On Feb 13, 2008 11:46 AM, [EMAIL PROTECTED] wrote: Quoting Jesse Becker [EMAIL PROTECTED]: Won't the INT, FLOAT, and NUMBER checks in valid_parameter() always be true? (float)$value would always be a float. Hmm...true. I was thinking of the case

Re: [Ganglia-developers] ideas on sanitizing variables.

2008-02-13 Thread alex
Quoting Jesse Becker [EMAIL PROTECTED]: On Feb 13, 2008 11:46 AM, [EMAIL PROTECTED] wrote: Quoting Jesse Becker [EMAIL PROTECTED]: You said the only patching would be to include this script in get_context.php and graph.php. So, I take that to mean that get_context.php and graph.php would

Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Carlo Marcelo Arenas Belon
On Wed, Feb 13, 2008 at 10:44:50AM -0800, Bernard Li wrote: So what's the latest? Can I check in my original patch to the branch? the original patch should work (if the spaces/tab is correct for the changes to get_context.php just like it was done in revision 964). Anything else needs to

Re: [Ganglia-developers] 3.0.7 release

2008-02-13 Thread Ulf
Hi, you know, my never ending wish is the integration of http://wtf.ath.cx/ganglia-dev/custom_graph_addon.tar.gz . The integration with 3.0.6 still works fine. After release of 3.0.7 I' ll test the versions with AIX and Solaris, too. The AIX version is probably without these patches