Re: RFC - Remove support for PCH post 4.8

2012-11-29 Thread Benjamin Kosnik
Assuming that the new implementation will be available in time for 4.9, my primary concern is that in the meanwhile running the libstdc++ testsuite will be quite noticeably slower. Do you have some numbers? Just use the numbers I used the last two times I tried to explain why PCH was

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-09 Thread Benjamin Kosnik
I'd like to know if my direction is ok. I can look into other issues releated to this and fix them, but it doesn't make much sense if separate build is not supported and can be easily broken in the future. I like your direction here. This patch is enough for 4.7 to have build working (at

[v3] libstdc++/54314

2012-09-26 Thread Benjamin Kosnik
adds in exports for more vtable bits, as per bugzilla -benjamin tested x86/linux tested x86/linux --enable-symvers=gnu-versioned-namespace012-09-26 Benjamin Kosnik b...@redhat.com PR libstdc++/54314 * config/abi/pre/gnu.ver: Add vtable exports. * config/abi/pre/gnu

Re: [v3] libstdc++/54102

2012-08-28 Thread Benjamin Kosnik
... finally got around to fixing up the generated HTML, so that charset is set to UTF-8. I regenerated doc/html and checked it in. Attached are the diffs. ... here using xhtml that will validate with W3c checkers. -benjamindiff --git a/libstdc++-v3/doc/Makefile.am

Re: [wwwdocs] Update coding conventions for C++

2012-06-26 Thread Benjamin Kosnik
With that concern stated, I will write into the conventions whatever concensus arises. Of course, I have no objection to an occasional inline cleanup. That is, build with -Werror and adjusting inlines that have, through the course of time, become larger than is useful. This seems to be

Re: [wwwdocs] Update coding conventions for C++

2012-06-25 Thread Benjamin Kosnik
Hey Lawrence, thanks for this work and for keeping the public up-to-date with this gcc-patches posting. This looks pretty good to me. The only remaining issue for me is the fuzzyness/handwaving around inlining. I think the only way to really enforce what can be inlined is not to have people

Re: Distributing 'make check' across a cluster

2012-05-31 Thread Benjamin Kosnik
Thanks. Having the source tree available is not a problem, as I require it to copy the actual testsuites into the work tree. Adding a few more files from the source tree would not be a problem. From: http://gcc.gnu.org/onlinedocs/libstdc++/manual/test.html You can run the tests with a

Re: [v3] libstdc++/52689 testcase

2012-04-25 Thread Benjamin Kosnik
it wasn't this simple. I see now that although this was not failing on my setup, it was coming in as unsupported to to my mis-use of the dg-require-target hook. Which was clearly not my intent... tested x86/linux -benjamin2012-04-25 Benjamin Kosnik b...@redhat.com PR libstdc++/52689

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Benjamin Kosnik
Hey hey! Looking good Dodji. Can't wait to use this stuff. There are so many libstdc++ tests that were failing because of that benign issue that I preferred to just run them with -ftrack-macro-expansion diabled, after inspecting each of them to be sure there was nothing more serious

Re: [v3] std::uninitialized_copy test

2012-04-17 Thread Benjamin Kosnik
Definitely, thanks! The name of the new testcase seems a bit weird (for the FSF branches): shall we maybe refer to the original (Fedora or RHEL Bugzilla, I suppose) PR in a comment and then use either an explicative name (our current practice) or just a small number for the name of the

Re: [v3] Update Solaris baselines for GCC 4.7, take 2

2012-03-01 Thread Benjamin Kosnik
After PRs libstdc++/52188 and libstdc++/52189 have been resolved, I'd finally like to update the Solaris baselines for the 4.7 release. This time, everything looks good: only additions to GLIBCXX_3.4.1[67], CXXABI_1.3.6, and CXXABI_TM_1, as expected. Bootstrapped without regressions on

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Benjamin Kosnik
On Tue, 28 Feb 2012 00:12:33 +0100 Jakub Jelinek ja...@redhat.com wrote: and $(EGREP) -v '#(#| |$$)' just throws away the whole };# Appended to version file. line. I wonder if sed -e 's/#[# $].*$//' wouldn't be better, or alternative add ^ before the first # in the egrep regex. Of course

Re: v3 PATCH to include/bits/locale_facets.h to revert reordering of virtual functions

2012-02-23 Thread Benjamin Kosnik
Thanks Jason. -benjamin

[v3] libstdc++/47058

2012-02-17 Thread Benjamin Kosnik
Adds support for disabling -Werror with --disable-werror configure flag. tested x86/linux --enable-maintainer-mode tested x86/linux --enable-maintainer-mode --disable-werror -benjamin2012-02-17 Benjamin Kosnik b...@redhat.com PR libstdc++/47058 * acinclude.m4 (GLIBCXX_ENABLE_WERROR

Re: [v3] libstdc++/51798

2012-02-17 Thread Benjamin Kosnik
Noticed that the config for the new atomic builtins was not correct for targets that did not do link tests. (ie x86-x-cris-elf). Fixed as follows. tested x86/linux tested x86/linux x cris-elf -benjamin2012-02-17 Benjamin Kosnik b...@redhat.com PR libstdc++/51798 continued

Re: obvious(?) typo in libstdc++-v3/src/c++98/locale.cc

2012-02-15 Thread Benjamin Kosnik
The typo is obvious, but whether or not the wrapped code still works isn't (to me). * src/c++98/locale.cc (locale::facet::_S_get_c_locale): Fix typo. Please check this in. -benjamin

Re: [v3] libstdc++/51798

2012-02-13 Thread Benjamin Kosnik
outside the loop. nice! Ok? cool, thanks for reviewing this. I fixed up the line numbers for the header file edits. -benjamin 2012-02-13 Benjamin Kosnik b...@redhat.com * testsuite/20_util/shared_ptr/cons/43820_neg.cc: Adjust line numbers. * testsuite/tr1/2_general_utilities/shared_ptr/cons

Re: [v3] Update C++11 status table.

2012-02-09 Thread Benjamin Kosnik
* doc/xml/manual/documentation_hacking.xml: Fix invalid attribute. Also committed to trunk. Tested with 'make doc-xml-validate-docbook doc-html' Doh! Thanks for cleaning up after my late-night hacking. If you can, I'd appreciate you trying to generate the PDF doxygen manual

[v3] libstdc++/51798

2012-02-09 Thread Benjamin Kosnik
This is the rest of 51798, completing the conversion to C++11 atomics in libstdc++. This is now a complete transition, modulo documentation which I plan to finish as a separate patch once I am back from the ISO C++ meeting. tested x86_64/linux -benjamin 2012-02-09 Benjamin Kosnik b

[v3] libstdc++/51811

2012-02-03 Thread Benjamin Kosnik
Fix-ups for atomic_tp* operators. Found some open issues with atomicvoid* that merit further study. tested x86/linux -benjamin2012-02-02 Benjamin Kosnik b...@redhat.com PR libstdc++/52068 * src/c++11/Makefile.am (toolexeclib_LTLIBRARIES, libc__11_la_SOURCES): Remove

Re: [v3] libstdc++/51811

2012-02-03 Thread Benjamin Kosnik
Different patch attached? Indeed, sorry. Here's the right one. -benjamin2012-02-03 Benjamin Kosnik b...@redhat.com PR libstdc++/51811 * include/bits/atomic_base.h (atomic_Tp*): Fix offsets. * testsuite/29_atomics/atomic/operators/51811.cc: New. * testsuite/29_atomics

[v3] libstdc++/49445

2012-02-03 Thread Benjamin Kosnik
+1,10 @@ 2012-02-03 Benjamin Kosnik b...@redhat.com + PR libstdc++/49445 + * testsuite/29_atomics/atomic/cons/49445.cc: Add. + +2012-02-03 Benjamin Kosnik b...@redhat.com + PR libstdc++/51811 * include/bits/atomic_base.h (atomic_Tp*): Fix offsets. * testsuite/29_atomics/atomic/operators

[v3] libstdc++/52068

2012-02-02 Thread Benjamin Kosnik
Remove install weirdness from 49829 fix. tested x86/linux -benjamin2012-02-02 Benjamin Kosnik b...@redhat.com PR libstdc++/52068 * src/c++11/Makefile.am (toolexeclib_LTLIBRARIES, libc__11_la_SOURCES): Remove. * src/c++11/Makefile.in: Regenerate. * src/c++98

Re: [v3] libstdc++/49829

2012-01-26 Thread Benjamin Kosnik
in. tested x86/linux -benjamin2012-01-27 Benjamin Kosnik b...@redhat.com Matthias Klose d...@ubuntu.com * configure.ac (GLIBCXX_ENABLE_DEBUG_FLAGS): Use -gdwarf-4 -g3 -O0. * configure.in: Regenerated. * src/Makefile.am (all-once, install-data-once): New rules. (all-local, install

Re: [RFC] libstdc++ atomic_flag changes

2012-01-24 Thread Benjamin Kosnik
The issue that I'm trying to solve is that we will have at least two targets whose test-and-set insn does not define set as 1, as a variable of type bool would expect. In the case of Sparc we *could* make the test-and-set implementation test for any non-zero value, but in the case of m68k

Re: [v3] libstdc++/49829

2012-01-24 Thread Benjamin Kosnik
this breaks builds configured with --enable-libstdcxx-debug. confirmed Tried the following (not yet working) fix. OK. The attached is closer, but still not quite there. -benjamindiff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am index 87b2a16..59cc57d 100644 ---

[v3] libstdc++/49829

2012-01-23 Thread Benjamin Kosnik
This modularizes the libstdc++ sources such that the resulting library binaries are now composed of three convenience libraries. In short: libstdc++.[a, so] == libc++98 + libc++11 + libsupc++ Arguably, this is the way it should have been done all along. And certainly since the C++11 support hit

Re: [v3] libstdc++/49829

2012-01-23 Thread Benjamin Kosnik
tested x86-64/linux tested x86-64/linux -x- arm-eabi tested x86-64/linux -x- cris-elf Here is the missing bit, as tested above. -benjamindiff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am index aa25a7e..87b2a16 100644 --- a/libstdc++-v3/src/Makefile.am +++

Re: Cross-build breakage with libstdc++-v3 doc changes

2012-01-18 Thread Benjamin Kosnik
, sorry. -benjamin 2012-01-18 Benjamin Kosnik b...@redhat.com * configure.ac: Move epub checks... * acinclude (GLIBCXX_CONFIGURE_DOCBOOK): ...here, use test -f instead of AC_CHECK_FILES. diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 index 9d08178..fd3ba96 100644

[v3] doc-epub rule updates

2012-01-17 Thread Benjamin Kosnik
This updates the support for generating epub docs to EPUB3. Using the EPUB3 stylesheets allows the removal of ruby and other tool checks from configure, and generates a much better documentation file. tested x86/linux -benjamin2012-01-17 Benjamin Kosnik b...@redhat.com * configure.ac

[v3] doc updates

2012-01-17 Thread Benjamin Kosnik
Regerate the html docs included in the source distribution. -benjamin 20120117-2.patch.bz2 Description: application/bzip

[v3] RFC libstdc++11convenience.la

2012-01-16 Thread Benjamin Kosnik
, the continued ad hoc nature of src/Makefile.am's current approach will break down. At some other point, we might want to start building a libstdc++11 library with different flags from src/c++03. This is how to get there. tested x86/linux -benjamin2012-01-16 Benjamin Kosnik b...@redhat.com Add libstdc

Re: C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-13 Thread Benjamin Kosnik
I think that's a bad idea; having too many ways to configure things will cause undue confusion. Seems like the train has already left the station WRT gcc configure options. If you feel this is a real issue, then it could be solved the same way that thread support was solved, by adding a

Re: C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-13 Thread Benjamin Kosnik
I like the idea, but not very strongly. I can live with having to say -std=c++11 (which I do via shell functions or scripts) Well, the actual C++11 compile/runtime environment is going to be more than just -std=c++11. It's looking something like -std=c++11 -fabi-version=7 + versioned

Re: C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-13 Thread Benjamin Kosnik
As it turns out, the mangling changes don't really impact the explicit instantiations compiled in to libstdc++.so. So, it seems possible to say Right, so people can use -fabi-version=0 and still use the installed libstdc++. I think a compelling case could be made to ship 4.7 with a

Re: C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-13 Thread Benjamin Kosnik
My concern is specifically about options for changing the default language version, not options for changing the libstdc++ ABI. More generally, about configure options affecting the semantics of code passed to GCC, as opposed to non-semantic configure options such as choosing the processor

Re: C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-13 Thread Benjamin Kosnik
Note that one of the objectives of this email is to try and get maintainers from thinking there is going to be a perfect time to switch. Development history tells us there will always be more changes. We've been sitting on ABI-breaking changes since 2003. e.g.

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-13 Thread Benjamin Kosnik
I went ahead and created a small patch with the changes above which is the second patch below and committed it. If you'd like to see some changes, just let me know. Thanks Gerald! This looks good. For the links, I just tried to add them where they'd been added before. Seems reasonable

Re: [v3] Link libstdc++ with -lpthread on IRIX 6 (PR target/47852)

2012-01-13 Thread Benjamin Kosnik
2011-02-25 Rainer Orth r...@cebitec.uni-bielefeld.de PR target/47852 * configure.host (irix6.5*): Add -lpthread to OPT_LDFLAGS. OK -benjamin

C++ ABI RFC [was Re: C++/libiberty PATCH for many mangling fixes (6057, 48051, 50855, 51322, etc)]

2012-01-12 Thread Benjamin Kosnik
bkoz pointed out that I forgot to update invoke.texi about -fabi-version=6. Applying to trunk I've been thinking about this. As it turns out, the mangling changes don't really impact the explicit instantiations compiled in to libstdc++.so. So, it seems possible to say 1. compile

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-12 Thread Benjamin Kosnik
+ h3Boolean type promotion changes/h3 + + p + The C compiler no longer promotes boolean values in arithmetic + statements to integer values. Configure-related code that checks for + C99's lt;stdbool.hgt; may be impacted. If the following line is + newly present in configure

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-12 Thread Benjamin Kosnik
Here's the page with links, more validation fixes, and removal of the C item. best, Benjamin2012-01-12 Benjamin Kosnik b...@redhat.com * htdocs/gcc-4.7/porting_to.html: Fixup for validation. * htdocs/gcc-4.7/changes.html: Add link to porting_to.html. * htdocs/gcc-4.6

[wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
As requested by Jakub. I thought it better to get this in, warts and all, and have it be corrected than to dally around again and have it not checked in. -benjamin2012-01-11 Benjamin Kosnik b...@redhat.com * htdocs/gcc-4.7/porting_to.html: Add. Index: htdocs/gcc-4.7/porting_to.html

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
validation fixups... -benjamin2012-01-11 Benjamin Kosnik b...@redhat.com * htdocs/gcc-4.7/porting_to.html: Fixup for validation. Index: htdocs/gcc-4.7/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
validation fixups... More of them -benjamin2012-01-11 Benjamin Kosnik b...@redhat.com * htdocs/gcc-4.7/porting_to.html: Fixup for validation. Index: htdocs/gcc-4.7/porting_to.html === RCS file: /cvs/gcc/wwwdocs

Re: Broken links (HTTP 404) on http://gcc.gnu.org/onlinedocs/

2012-01-09 Thread Benjamin Kosnik
I would like to report some broken links on http://gcc.gnu.org/onlinedocs/ Namely links to PDF version of GCC 4.6.2 Standard C++ Library Reference Manual and GCC 4.6.2 Standard C++ Library Manual referencing http://gcc.gnu.org/onlinedocs/gcc-4.6.2/libstdc++/libstdc++-manual.pdf.bz2

[v3] add -Wabi to build flags

2012-01-09 Thread Benjamin Kosnik
a lot of code. tested x86/linux -benjamin2012-01-09 Benjamin Kosnik b...@redhat.com * fragment.am (WARN_CXXFLAGS): Add -Wabi. * Makefile.in: Regenerate. * doc/Makefile.in: Same. * include/Makefile.in: Same. * libsupc++/Makefile.in: Same. * src/Makefile.in: Same

[wwwdocs] correct libstdc++ links

2012-01-09 Thread Benjamin Kosnik
Correct libstdc++ naming convention to be the same as used by the other html tarballs, ie library-html.tar.bz2. I just checked this in as I was fixing the recent gcc mailing list report of broken links. -benjamin2012-01-09 Benjamin Kosnik b...@redhat.com * onlinedocs/index.html: Use

Re: [patch libstdc++]: Fix PR/51673

2012-01-09 Thread Benjamin Kosnik
new/delete operators signature for LLP64 size_t, and adjusted signatures for mt-allocator using size_t. 2012-01-09 Benjamin Kosnik b...@redhat.com PR libstc++/51673 part 1 * config/abi/pre/gnu-versioned-namespace.ver: Sync cxxabi symbols with gnu.ver. diff --git a/libstdc++-v3/config/abi

[v3] fix num_put/.../9780-2 for recent glibcs

2011-12-15 Thread Benjamin Kosnik
2.14.90-212011-12-15 Benjamin Kosnik b...@redhat.com * testsuite/22_locale/num_put/put/char/9780-2.cc: Add test for C locale, add sanity checks in case of grouping. diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/char/9780-2.cc b/libstdc++-v3/testsuite/22_locale/num_put

Re: [v3] doxygen warnings

2011-12-12 Thread Benjamin Kosnik
This patch just removes/restructures some of the doxygen markup to avoid warnings when generating the documentation. Most of the libstdc++ headers are pretty doxygen clean now. By the way, I recently made this feature request for Doxygen:

Re: [v3] RFC: rename __calculate_memory_order

2011-12-07 Thread Benjamin Kosnik
* include/bits/atomic_base.h (__calculate_memory_order): Rename to... (__cmpexch_failure_order): This, and rewrite as constexpr function. (compare_exchange_strong, compare_exchange_weak): Use it. * include/std/atomic (compare_exchange_strong, compare_exchange_weak):

Re: [PATCH] Re: [v3] updated atomic configury

2011-11-30 Thread Benjamin Kosnik
Thanks Andrew. Here's the updated patch, as checked in. This removes one level of cruft WRT atomic configure-ness (leaving us with the most primordial...). tested x86/linux tested x86/linux x arm-eabi tested x86/linux x cris-elf -benjamin 2011-11-30 Benjamin Kosnik b...@redhat.com

[v3] updated atomic configury

2011-11-21 Thread Benjamin Kosnik
, yeah! #endif But this doesn't seem to work. And what I have in this patch, which is #if defined(ATOMIC_INT_LOCK_FREE) doesn't really say the same thing... -benjamin tested x86/linux tested x86/linux x cris-elf tested x86/linux x arm-eabi-elf2011-11-21 Benjamin Kosnik b...@redhat.com

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-11 Thread Benjamin Kosnik
I just realized I may be feeding you an inconsistent configuration, see the atomicity stuff in libstdc++-v3/config/cpu/cris. Is that just obsolete and unused now or what do I need to add for that to work? You don't need to do anything there. I think that atomicity stuff will soon

Re: [v3] doxygen markup for tr2

2011-11-04 Thread Benjamin Kosnik
One more buglet -benjamin2011-11-04 Benjamin Kosnik b...@redhat.com * scripts/run_doxygen: Fix sed quoting. diff --git a/libstdc++-v3/scripts/run_doxygen b/libstdc++-v3/scripts/run_doxygen index 3fef95f..7b601bc 100644 --- a/libstdc++-v3/scripts/run_doxygen +++ b/libstdc++-v3/scripts

[v3] doxygen markup for tr2

2011-11-03 Thread Benjamin Kosnik
Some doxygen markup tweaks to get the tr2 components to show up. Also, I've regenerated doc/html. tested x86/linux -benjamin 2011-11-03 Benjamin Kosnik b...@redhat.com * doc/doxygen/doxygroups.cc: Add markup for namespace tr2. * include/tr2/bool_set: Adjust doxygen markup. * include/tr2

[v3] tr2 missing bits

2011-11-01 Thread Benjamin Kosnik
Ooops, noticed some minor bits when I was regenerating the docs. Some of the TR2 man pages needed munging, and the c++config bits for versioning TR2 needed to go in. tested x86/linux best, benjamin 2011-11-02 Benjamin Kosnik b...@redhat.com * include/bits/c++config: Add tr2

Re: Potentially merging cxx-mem-model with mainline.

2011-10-26 Thread Benjamin Kosnik
Whats left === Functionality is pretty much complete, but there are a few minor lose ends still to deal with. They could be done after a merge, in the next stage, or required before... you tell me :-) - potentially implement -f[no]-inline-atomics (to never produce inline code

Re: Intrinsics for N2965: Type traits and base classes

2011-10-19 Thread Benjamin Kosnik
Please post a ChangeLog entry with a patch. Someone added one for you: 2011-10-17 Michael Spertus mike_sper...@symantec.com * gcc/c-family/c-common.c (c_common_reswords): Add __bases, __direct_bases. * gcc/c-family/c-common.h: Add RID_BASES and RID_DIRECT_BASES.

[v3] tr2: bool_set, dynamic_bitset, ratio

2011-10-19 Thread Benjamin Kosnik
Hi Edward! I have reviewed and selectively merged your development branch, libstdcxx-tr2-ideas-branch, into trunk. As ISO C++ is now looking at new library efforts for TR2 (and N2965 has already been checked in to trunk) I thought it well-timed. Please check my work, patch attached. On

Re: [v3] Remove duplicate symbol in gnu.ver (PR bootstrap/50715)

2011-10-17 Thread Benjamin Kosnik
Agh. Sorry about this Rainer. Thanks for the patch. -benjamin

Re: Intrinsics for N2965: Type traits and base classes

2011-10-17 Thread Benjamin Kosnik
+ + * include/tr2/type_traits (bases, direct_bases, typelist): New. + +2011-10-17 Benjamin Kosnik b...@redhat.com + + * libstdc++-v3/include/Makefile.am: Add tr2 directory and includes. + * libstdc++-v3/include/Makefile.in: Regenerate. + + * scripts/create_testsuite_files: Search tr2 directory. + * testsuite

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-10-11 Thread Benjamin Kosnik
I realized this one hasn't made it in, but is really nice. I made a number of minor edits (typos, markup, simplifying headings,... among others). What do you think -- should we include this? Many users still won't have GCC 4.6 deployed yet, so I think it's still worth it. What do

Re: [v3] cxxabi.h vs. unwind-cxx.h

2011-10-10 Thread Benjamin Kosnik
Here's a patch that works for both C and C++. tested x86/linux -benjamin 2011-10-10 Benjamin Kosnik b...@redhat.com PR libstdc++/49818 * config/abi/pre/gnu.ver (CXXABI_1.3.6): Add symbols. * testsuite/util/testsuite_abi.cc: Same. * libsupc++/unwind-cxx.h: Move required eh API

Re: Intrinsics for N2965: Type traits and base classes

2011-10-10 Thread Benjamin Kosnik
This is looking pretty good, from the libstdc++ side. This latest round of gcc hacking fixes the previous testsuite fixes, so once you get the gcc bits OK'd by Jason you can check in. I'd still like to see some testcases for the intrinsic, independent of the library. Seems like some simple

Re: [v3] use NSDMI in C++11 mutex types

2011-10-06 Thread Benjamin Kosnik
Does anyone have any comments or objections to going in this direction? If the new base classes aren't OK the NSDMI syntax could still be used, just without refactoring to remove the code duplication. I like where you are going here. This looks good to me. -benjamin

Re: [v3] versioned-namespaces spelling/soname change

2011-10-06 Thread Benjamin Kosnik
... I went ahead and reverted the change, wasn't documented anywhere, definitely unintended. Thanks -benjamin

[v3] cxxabi.h vs. unwind-cxx.h

2011-10-06 Thread Benjamin Kosnik
Benjamin Kosnik b...@redhat.com PR libstdc++/49818 * config/abi/pre/gnu.ver (CXXABI_1.3.6): Add symbols. * testsuite/util/testsuite_abi.cc: Same. * libsupc++/unwind-cxx.h: Move required eh API... * libsupc++/cxxabi.h: ... to here. Add required forward declarations. * libsupc++/pure.cc

Re: [v3] versioned-namespaces spelling/soname change

2011-10-05 Thread Benjamin Kosnik
I'm going to let this chill a bit on mainline and then check in to 4.6.x. Seems fine so I dropped this into the 4_6-branch tested x86/linux -benjamin 2011-10-05 Benjamin Kosnik b...@redhat.com Jonathan Wakely jwakely@gmail.com PR libstdc++/48698

Re: Intrinsics for N2965: Type traits and base classes

2011-10-03 Thread Benjamin Kosnik
OK. Here is a new diff that hopefully takes into account all of Jason's and Benjamin's comments. Benjamin's TR2 build patch is not repeated (or tested!) here. Benjamin, I'd really appreciate if you wouldn't mind confirming I handled that correctly in tr2/type_traits (Including the inclusion

Re: Intrinsics for N2965: Type traits and base classes

2011-09-29 Thread Benjamin Kosnik
OK. Here are some simple benchmarks. I simulated heavy use of reflection with 1000 classes that each had about a thousand base classes. I also created a super-simple typelist class templatetypename... T struct typelist {}; // Variadic templates rock If bases returns a typelist, the

Re: Intrinsics for N2965: Type traits and base classes

2011-09-27 Thread Benjamin Kosnik
Oops, this is the right patch. -benjamindiff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index a59a0b6..e1176ee 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,14 @@ 2011-09-27 Benjamin Kosnik b...@redhat.com + * doc/Makefile.am: Add tr2 support

[v3] versioned-namespaces spelling/soname change

2011-09-26 Thread Benjamin Kosnik
-09-26 Benjamin Kosnik b...@redhat.com Jonathan Wakely jwakely@gmail.com PR libstdc++/48698 * acinclude.m4 (GLIBCXX_ENABLE_SYMVERS): Set libtool_VERSION here. * configure.ac: Move AC_SUBST of libtool_VERSION past call to GLIBCXX_ENABLE_SYMVERS. * configure: Regenerate

[v3] doc-epub

2011-09-21 Thread Benjamin Kosnik
Fix for image directory location. The generated epub is ok, but missing images. There's another tool that may be used to generate epubs, called db2epub.py, but it isn't cooperating. So we will stick with the status quo for now. -benjamin2011-09-21 Benjamin Kosnik b...@redhat.com * doc

Re: [v3] tuple round 2

2011-09-07 Thread Benjamin Kosnik
2011-08-03 Benjamin Kosnik b...@redhat.com François Dumont francois.cppd...@free.fr * testsuite/23_containers/array/at_neg.cc: Move... * testsuite/23_containers/array/at.cc: ...here. Remove -fno-exceptions, call const at member function. I've reverted

[v3] constexpr tuple

2011-09-06 Thread Benjamin Kosnik
Benjamin Kosnik b...@redhat.com * include/std/tuple (_Tuple_impl::_M_head, _M_tail): Mark constexpr. (tuple(tuple)): Same. (tuple(const tuple_UElements... __in)): Same. (tuple(tuple_UElements... __in)): Same. (tuple_cat(const tuple_TElements..., const tuple_UElements...)): Same. (get

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-24 Thread Benjamin Kosnik
Any comments on this? I'd like to get it in; Phil found a bug in the std::tuple printer, and it would be nice to put in a test case along with the fix. Hey Tom (and Phil!). Sorry for the delay: this looks fine. Please put it in on trunk and enjoy your vacation! -benjamin

Re: [v3] doxygen markup fixes

2011-08-08 Thread Benjamin Kosnik
+/** @file bits/alloc_traits.h + *  This is an internal header file, included by other library headers. + *  Do not attempt to use it directly. @headername{scoped_allocator} + */ + The correct header for allocator_traits is memory Ack. Thanks for the review. Kind of

[v3] docbook vs. images

2011-08-04 Thread Benjamin Kosnik
This fixes the docbook html output with respect to images. Now, filerefs for PNG data are relative to the html install directory, and an images directory is copied and populated so that the links match PNG files. tested x86/linux -benjamin2011-08-04 Benjamin Kosnik b...@redhat.com * doc/xml

[v3] tuple round 2

2011-08-03 Thread Benjamin Kosnik
Hey this fixes up the array::at issue as pointed out on this list. In addition, it adds some more tuple markup for constexpr. I'm going to stage in the tuple work, as some of it is more controversial. tested x86/linux -benjamin2011-08-03 Benjamin Kosnik b...@redhat.com * include/std/tuple

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-03 Thread Benjamin Kosnik
+++ b/libstdc++-v3/acinclude.m4 @@ -685,9 +685,9 @@ AC_DEFUN([GLIBCXX_EXPORT_INCLUDES], [ fi # Stuff in the actual top level. Currently only used by libsupc++ to - # get unwind* headers from the gcc dir. - #TOPLEVEL_INCLUDES='-I$(toplevel_srcdir)/gcc

[v3] check-performance compile fail cleanup

2011-08-03 Thread Benjamin Kosnik
These tests recently started failing at compile time for me due to no declarations for unlink due to no include of unistd.h. So, I did the obvious thing and included it. tested x86/linux -benjamin2011-08-03 Benjamin Kosnik b...@redhat.com * testsuite/performance/27_io/filebuf_sputn_unbuf.cc

[v3] docbook biblioid/imagedata markup fixes

2011-07-29 Thread Benjamin Kosnik
As noted earlier today, this removes various warnings when processing doc/xml/* files. tested x86/linux -benjamin2011-07-29 Benjamin Kosnik b...@redhat.com * doc/xml/manual/build_hacking.xml: Markup imagedata changes. * doc/xml/manual/policy_data_structures.xml: Same. * doc/xml

[v3] constexpr pair additions

2011-07-22 Thread Benjamin Kosnik
Add constexpr markup to move/forward, and enable more std::pair constructors. tested x86/linux -benjamin2011-07-22 Benjamin Kosnik b...@redhat.com Daniel Krugler daniel.krueg...@googlemail.com * include/bits/move.h (move, forward): Mark constexpr. * include/bits/stl_pair.h (pair

[v3] testsuite renames

2011-07-21 Thread Benjamin Kosnik
Some shortened pathnames from doc cleanup branch. tested x86/linux -benjamin2011-07-21 Benjamin Kosnik b...@redhat.com * testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Move... * testsuite/ext/pb_ds/regression/tree_set_rand.cc: ... here. * testsuite/ext/pb_ds

[v3] constexpr n3291 missing bits

2011-07-20 Thread Benjamin Kosnik
While reviewing the state of gcc constexpr vs. ISO C++, I noticed that the bitset access operator was missing, so I added it thusly. Like ice cream on a hot summer day, the expanded constexpr diagnostics do not disappoint. Thanks Jason! An example:

Re: Remove NetWare support

2011-07-20 Thread Benjamin Kosnik
diff --git a/libstdc++-v3/crossconfig.m4 b/libstdc++-v3/crossconfig.m4 --- a/libstdc++-v3/crossconfig.m4 +++ b/libstdc++-v3/crossconfig.m4 @@ -173,14 +173,6 @@ case ${host} in AC_DEFINE(HAVE_ISNANL) fi ;; - *-netware) -SECTION_FLAGS='-ffunction-sections

[v3] constexpr time_point additions

2011-07-20 Thread Benjamin Kosnik
system_clock steady_clock; #endif typedef system_clock high_resolution_clock; Index: ChangeLog === --- ChangeLog (revision 176534) +++ ChangeLog (working copy) @@ -1,3 +1,20 @@ +2011-07-20 Benjamin Kosnik b...@redhat.com + Daniel

[v3] constexpr array additions

2011-07-20 Thread Benjamin Kosnik
[]! tested x86/linux -benjamin2011-07-20 Benjamin Kosnik b...@redhat.com Daniel Krugler daniel.krueg...@googlemail.com * include/std/array (array::at, array::operator[]): Mark constexpr. * testsuite/23_containers/array/requirements/ constexpr_element_access.cc: Add. Index: include/std

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

2011-04-28 Thread Benjamin Kosnik
2011-04-27 Doug Kwan dougk...@google.com * include/Makefile.am (install-freestanding-headers): Also install cxxabi_tweaks.h. * include/Makefile.in: Regnerate. OK for trunk and 4.6 -benjamin

Re: [wwdocs] add libstdc++ docs for 4.6.0

2011-04-06 Thread Benjamin Kosnik
I ended up fiddling a bit with permissions and such, but everything should be in place now and I also committed the web patch on your behalf. Thanks! This pleases me a great deal. Testing the links, there is one thing does does not work, and where I was not sure how to address it: The

[wwdocs] add libstdc++ docs for 4.6.0

2011-04-05 Thread Benjamin Kosnik
++ into /sourceware/www/gcc/htdocs/onlinedocs/gcc-4.6.0 best, benjamin2011-04-05 Benjamin Kosnik b...@redhat.com * htdocs/onlinedocs/index.html: Add libstdc++ documentation for 4.6.0. Index: htdocs/onlinedocs/index.html

Re: [PATCH] sparc and alpha baseline_symbols.txt update

2011-03-23 Thread Benjamin Kosnik
2011-03-22 Matthias Klose d...@ubuntu.com * config/abi/post/sparc-linux-gnu/baseline_symbols.txt: Regenerated. 2011-03-22 Uros Bizjak ubiz...@gmail.com * config/abi/post/alpha-linux-gnu/baseline_symbols.txt: Regenerated. Yay. Jakub I'm deferring to you on this, your

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-23 Thread Benjamin Kosnik
2011-03-15 Rainer Orth r...@cebitec.uni-bielefeld.de * config/abi/post/solaris2.8/baseline_symbols.txt: Regenerate. * config/abi/post/solaris2.8/sparcv9/baseline_symbols.txt: Likewise. * config/abi/post/solaris2.10/baseline_symbols.txt: Likewise. *

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Benjamin Kosnik
Here is updated patch with testcases, tested with unpatched libstdc++ where it failed to link and patched where it succeeded. The testcases are copies of corresponding moveable.cc tests, just using the new class inheriting from std::basic_stringchar resp. std::basic_stringwchar_t and with

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-19 Thread Benjamin Kosnik
2011-03-19 Jakub Jelinek ja...@redhat.com * config/abi/pre/gnu.ver (CXXABI_1.3): Don't export _ZT[IS][PK]*[no]. (CXXABI_1.3.5): Export _ZTI[PK]*[no]. This looks good to me, nice catch. I'll figure out what happened with check_abi when I'm back, conductivity-wise. And: And

Re: [v3] typeinfo tuning

2011-03-16 Thread Benjamin Kosnik
Could that be related to the fact that I now keep getting linker errors about std::range_error::~range_error() being undefined? The .o file is looking for _ZNSt11range_errorD2Ev but libstdc++ has D0Ev and D1Ev. Indeed. Fixed thusly. tested x86/linux -benjamin 2011-03-16 Benjamin Kosnik

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Benjamin Kosnik
I think we agreed that it would be useful to regenerate the Solaris 2 libstdc++ baselines close to the GCC 4.6.0 release, especially given that symbol versioning on Solaris appears in 4.6.0 for the first time and several symbols have been added to the libstdc++.so ABI since the last update.

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Benjamin Kosnik
++, or the freestanding version. (ie to GLIBCXX from CXXABI). I think this was probably a simple thinko, right Paolo? If it's not, I'm not sure of the rationale and would appreciate any commentary. best, benjamin2011-03-15 Benjamin Kosnik b...@redhat.com * config/abi/pre/gnu.ver: Make nested_exception exports

  1   2   3   >